Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set labels on Cluster object via ManagedCluster #801

Open
wahabmk opened this issue Dec 16, 2024 · 0 comments · May be fixed by #809
Open

Set labels on Cluster object via ManagedCluster #801

wahabmk opened this issue Dec 16, 2024 · 0 comments · May be fixed by #809
Assignees
Labels
enhancement Small feature, request or improvement suggestion

Comments

@wahabmk
Copy link
Contributor

wahabmk commented Dec 16, 2024

In the MultiClusterService object we use the label selectors to match CAPI clusters, e.g:

apiVersion: hmc.mirantis.com/v1alpha1
kind: MultiClusterService
metadata:
  name: myappz-global
spec:
  servicesPriority: 1000
  clusterSelector:
    matchLabels:
      env: dev3
  services:
    - template: ingress-nginx-4-11-3
      name: ingress-nginx
      namespace: ingress-nginx

Currently to match the clusters we want to this MultiClusterService, we need to manually add env: dev3 label to the Cluster objects.

We should make it so that the labels on Cluster object can be assigned via the ManagedCluster object.

@wahabmk wahabmk self-assigned this Dec 16, 2024
@wahabmk wahabmk moved this from Todo to In Progress in Project 2A Dec 17, 2024
@wahabmk wahabmk linked a pull request Dec 18, 2024 that will close this issue
@DinaBelova DinaBelova added the enhancement Small feature, request or improvement suggestion label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Small feature, request or improvement suggestion
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants