managedcluster-controller tests #830
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BROngineer
force-pushed
the
fix/issue-822-managedcluster-controller-test
branch
5 times, most recently
from
20e9cdb to
8010dd2
Compare
BROngineer
requested review from
Kshatrix,
eromanova,
a13x5 and
zerospiel
as code owners
zerospiel
reviewed
Dec 30, 2024
Comment on lines
+49
to
+59
| getter := NewMemoryRESTClientGetter(a.Config, a.RESTMapper) | ||
| actionConfig := new(action.Configuration) | ||
| err := actionConfig.Init(getter, clusterDeployment.Namespace, "secret", log) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| return actionConfig, nil |
There was a problem hiding this comment.
Suggested change
| getter := NewMemoryRESTClientGetter(a.Config, a.RESTMapper) | |
| actionConfig := new(action.Configuration) | |
| err := actionConfig.Init(getter, clusterDeployment.Namespace, "secret", log) | |
| if err != nil { | |
| return nil, err | |
| } | |
| return actionConfig, nil | |
| actionConfig := new(action.Configuration) | |
| return actionConfig, actionConfig.Init(NewMemoryRESTClientGetter(a.Config, a.RESTMapper), clusterDeployment.Namespace, "secret", log) |
There was a problem hiding this comment.
@zerospiel is it ok for our code-style, that the function returning pointer and error, will return pointer to type's zero value along with an error? Isn't it more correct to return nil, err in case of error and value, nil in case no error occurred?
Besides that, is it really worth packing all calls into a single-line return if it doesn't affect anything other than readability (which is very subjective measurement)?
There was a problem hiding this comment.
just nitting, it was a suggestion obviously to my own style/preferences , up to the developer though
Signed-off-by: Artem Bortnikov <[email protected]>
Signed-off-by: Artem Bortnikov <[email protected]>
Signed-off-by: Artem Bortnikov <[email protected]>
Signed-off-by: Artem Bortnikov <[email protected]>
Signed-off-by: Artem Bortnikov <[email protected]>
Signed-off-by: Artem Bortnikov <[email protected]>
Signed-off-by: Artem Bortnikov <[email protected]>
Signed-off-by: Artem Bortnikov <[email protected]>
BROngineer
force-pushed
the
fix/issue-822-managedcluster-controller-test
branch
from
fe7bc24 to
58f8620
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #822