Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logic error in the airgap-bundle script #842

Open
a13x5 opened this issue Dec 27, 2024 · 0 comments
Open

Logic error in the airgap-bundle script #842

a13x5 opened this issue Dec 27, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@a13x5
Copy link
Contributor

a13x5 commented Dec 27, 2024

Describe the bug

When trying to create airgap package, the script fails with the following error:

Error: expected at most two arguments, unexpected arguments: openstack-csi, openstack-csi-values.yaml
Error: Failed to get images from Helm template for openstack-ccm
openstack-csi, trying to output values with debug...
install.go:222: [debug] Original chart version: "2.31.1"
Error: expected at most two arguments, unexpected arguments: openstack-csi, openstack-csi-values.yaml
helm.go:84: [debug] expected at most two arguments, unexpected arguments: openstack-csi, openstack-csi-values.yaml
helm.sh/helm/v3/pkg/action.(*Install).NameAndChart
        helm.sh/helm/v3/pkg/action/install.go:652
main.runInstall
        helm.sh/helm/v3/cmd/helm/install.go:228
main.newTemplateCmd.func2
        helm.sh/helm/v3/cmd/helm/template.go:95
github.com/spf13/cobra.(*Command).execute
        github.com/spf13/[email protected]/command.go:983
github.com/spf13/cobra.(*Command).ExecuteC
        github.com/spf13/[email protected]/command.go:1115
github.com/spf13/cobra.(*Command).Execute
        github.com/spf13/[email protected]/command.go:1039
main.main
        helm.sh/helm/v3/cmd/helm/helm.go:83
runtime.main
        runtime/proc.go:271
runtime.goexit
        runtime/asm_amd64.s:1695
Error: Failed to get images from Helm template for openstack-ccm
openstack-csi with debug output
make: *** [Makefile:168: bundle-images] Error 1

To Reproduce

  1. Run make airgap-package

Additional context

The error happens because of false assumption that chart repositories will always be unique and will map 1-1 to all charts in the list. With introduction of openstack template (which has 2 charts in the single repo) script breaks really bad trying to process both charts at the same time.

@a13x5 a13x5 added the bug Something isn't working label Dec 27, 2024
@a13x5 a13x5 self-assigned this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

1 participant