Add bastion configuration for AWS templates #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kshatrix
requested changes
Aug 12, 2024
docs/aws/cluster-parameters.md
Outdated
| Only one SSH key is supported and it should be added in AWS preor creating | ||
| the `Deployment` object name of the key then can be placed under `.spec.config.sshKeyName` | ||
|
|
||
| For the bastion host key named **default** must be created, since setting key name |
There was a problem hiding this comment.
sshKeyName is supposed to be used for all instances in the cluster, including the bastion host. could you please check?
There was a problem hiding this comment.
I overlooked this parameter. Then it makes sense to just use it and drop sshKeyName parameters in AWSMachineTemplate as I did it the latest push.
Kshatrix
approved these changes
Aug 13, 2024
bnallapeta
pushed a commit
to bnallapeta/hmc
that referenced
this pull request
Nov 15, 2024
Add bastion configuration for AWS templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #173