Add Azure AKS Cluster Template #806
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eromanova
force-pushed
the
aks-template
branch
from
56df32f to
572aa14
Compare
eromanova
force-pushed
the
aks-template
branch
from
572aa14 to
125b7c8
Compare
zerospiel
reviewed
Dec 20, 2024
| @@ -84,6 +84,10 @@ type ManagedClusterSpec struct { | |||
| // By default the remaining services will be deployed even if conflict is detected. | |||
| // If set to true, the deployment will stop after encountering the first conflict. | |||
| StopOnConflict bool `json:"stopOnConflict,omitempty"` | |||
| // PropagateCredentials indicates whether credentials should be propagated | |||
| // for use by CCM (Cloud Controller Manager). | |||
| // Default: true. | |||
There was a problem hiding this comment.
i cannot see the kubebuilder default directive, nor where it is being defaulted via the mutation webhook, could you show me where it is being defaulted to such a value? and why should the field be nullable in the case when true is the default value?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes:
azure-aksclusters has been added.propagateCredentials: false. This is particularly needed for AKS clusters, as they do not require credential propagation.There are two API options for creating AKS clusters:
ManagedClusterandASOManagedCluster. TheASOManagedClusterapproach was chosen because theManagedClusterwill eventually be deprecated. See CAPZ ManagedCluster vs. ASOManagedCluster.ASO Credentials
ASO (azure service operator) requires Azure credentials to be defined in a Kubernetes Secret and does not support reading creds from
AzureClusterIdentity(source: https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/main/docs/proposals/20230123-azure-service-operator.md#security-model).Closes #744