fix: remove ub from some logic errors

MiroPalmu · Jan 18, 2025 · a65efbc · a65efbc
1 parent 6c88b62
commit a65efbc
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/fd_handle.cpp b/src/fd_handle.cpp
@@ -81,7 +81,7 @@ void fd_handle::close() {
         case 0: return;
         case -1: sstd::throw_generic_system_error();
     }
-    std::unreachable();
+    throw std::logic_error{ "Unregonized error code from gnulib::close(fd)." };
 }
 
 auto fd_handle::get_PIPE_BUF() const -> unsigned long {

diff --git a/src/memory_block.cpp b/src/memory_block.cpp
@@ -79,7 +79,7 @@ namespace {
             }
             return fd;
         }
-        std::unreachable();
+        throw std::logic_error{ "Unhandeled state from fd_safer_flag(fd, O_CLOEXEC)." };
     }
     throw std::runtime_error{
         std::format("Could not create POSIX shm object with unique name after {} times.", max_tries)

diff --git a/src/pipe.cpp b/src/pipe.cpp
@@ -38,7 +38,7 @@ namespace gnulander {
         case 0: return { fd_handle{ raw_pipe_fd.front() }, fd_handle{ raw_pipe_fd.back() } };
         case -1: sstd::throw_generic_system_error();
     }
-    std::unreachable();
+    throw std::logic_error{ "Unregonized error code from ::pipe2_safer(fd, O_CLOEXEC)." };
 }
 
 } // namespace gnulander