Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes when no value entered #18

Open
tomek-szczesny opened this issue Jul 22, 2023 · 10 comments
Open

Crashes when no value entered #18

tomek-szczesny opened this issue Jul 22, 2023 · 10 comments
Assignees

Comments

@tomek-szczesny
Copy link

Hi again,

The script crashes when the "step y" field is empty (the only thing I tested).
It crashes somewhere where commas are replaced by dots I think.
Looks like a matter of sanity check, if the field is empty then it should be filled with "0".

By the way all fields could be empty by default, so it's easier to do the same thing multiple times by pasting values on each run.

@MitjaNemec
Copy link
Owner

Thanks for reporting.

I'll look into if I can save previously used values within a particular project

@tomek-szczesny
Copy link
Author

That would be awesome, for now I modified the default values in the script when I had 40 components to place. :)
Perhaps those values per project could be stored in a text box on some User Drawing layer?
Then the user could delete it if they are bothered with it, or copy it to another PCB if they want to.

@MitjaNemec
Copy link
Owner

Well I'll either store the settings as a dedicated file in the project folder which would make the editing simple. But to be honest I'd rather store them in OS temporary folder, as some users with extreme OCD like to keep the project folder tidy. And they will likely complain if I start messing up the project folder or godforbid even the project itself (User Drawing layer)

@MitjaNemec
Copy link
Owner

So, I've added:

  • the feature which saves/restores used configuration
  • prevents running the plugin on missing entries, and highlights missing entries.

You can check the 2.1.1 release by manually installing from file, as it will be a while before it is updated in PCM

@tomek-szczesny
Copy link
Author

Awesome, thanks :) I won't have an opportunity to check this out anytime soon because I've just finished a batch of layouts. But if your tests say it's working I don't feel that I have anything meaningful to contribute here.
The issue may be closed now

@tomek-szczesny
Copy link
Author

Okay I got an extra assignment so I updated the plugin to 2.1.1.

Seems like there might be a regression unfortunately. Now when I want to place footprints by sheet number, the "sheets to replicate" box is empty, and plugin does nothing.

The step value is not saved either, I cannot see an extra file being created anywhere.

Same applies to version 2.1.0.

Back to version 2.0.3 and everything works fine again.

Please let me know if I can help debug this. I work on Manjaro Linux if that matters.

@MitjaNemec
Copy link
Owner

Thanks for reporting this. It should be fixed in 2.1.2

@tomek-szczesny
Copy link
Author

Hi,
I'm testing 2.1.2 right now.
The regression is gone, the tool is working again. For any reason I have to use negative X coordinate to place footprints on the right, but that might be an issue with sheet enumeration in this project.

It still doesn't remember settings, and I can't see any file created in project directory, though.

@MitjaNemec
Copy link
Owner

MitjaNemec commented Oct 13, 2023

Reopening, so that I don't forget that:

It still doesn't remember settings, and I can't see any file created in project directory, though.
in the per sheet mode

@MitjaNemec MitjaNemec reopened this Oct 13, 2023
@MitjaNemec MitjaNemec self-assigned this Oct 13, 2023
@MitjaNemec
Copy link
Owner

@tomek-szczesny, I've tested the plugin throughly and I did not have any issues with saving the config either in "per reference" or in "per sheet" mode.

Can you update to 2.1.3 and retest the plugin. If you notice any issues please remember to store the .log file and attach it here. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants