-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOP-2330] - add KeyValueHwm, KeyValueIntHwm classes #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b11e31f
to
dc3c303
Compare
dc3c303
to
1f2a53e
Compare
1f2a53e
to
0e1373b
Compare
0e1373b
to
1474395
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #71 +/- ##
===========================================
+ Coverage 96.37% 96.45% +0.08%
===========================================
Files 48 50 +2
Lines 1075 1128 +53
Branches 192 202 +10
===========================================
+ Hits 1036 1088 +52
Misses 23 23
- Partials 16 17 +1 ☔ View full report in Codecov by Sentry. |
b6e5fc5
to
27b8b7a
Compare
f8c3bd6
to
9fa9517
Compare
dolfinus
reviewed
Jan 9, 2024
dolfinus
reviewed
Jan 9, 2024
dolfinus
reviewed
Jan 9, 2024
dolfinus
reviewed
Jan 9, 2024
dolfinus
reviewed
Jan 9, 2024
dolfinus
reviewed
Jan 9, 2024
dolfinus
reviewed
Jan 9, 2024
dolfinus
reviewed
Jan 9, 2024
353fa6d
to
91e9614
Compare
91e9614
to
0f6f295
Compare
dolfinus
reviewed
Jan 9, 2024
dolfinus
reviewed
Jan 9, 2024
988e152
to
72a5991
Compare
dolfinus
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
KeyValueIntHWM
class, designed to manage HWM for partitioned data sources like Kafka topics.cover
method from baseHWM
class and its use with following tests in child classesRelated issue number
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rst
file added describing change(see CONTRIBUTING.rst for details.)