Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Source Link issues caused by # usage in paths #245

Open
PathogenDavid opened this issue Jun 24, 2022 · 0 comments
Open

Fix Source Link issues caused by # usage in paths #245

PathogenDavid opened this issue Jun 24, 2022 · 0 comments
Labels
External Issues which represent work which affects Biohazrd but needs to happen outside of Biohazrd

Comments

@PathogenDavid
Copy link
Member

Turns out the #'s we use for organizational folders break Source Link in many contexts, seemingly because the # is not being escaped as %23.

Ideally this should just be fixed externally, I've reported the issue to the relevant parties here:

If this doesn't get fixed upstream, I think we could potentially fix this by generating our own sourcelink.json which has the # pre-escaped. IE:

{
  "documents": {
    "/_/*": "https://raw.githubusercontent.com/MochiLibraries/Biohazrd/f888ef20336e649f9cbc1fe0aeb4aae6b29d70db/*",
    "/_/external/assert.xunit/*": "https://raw.githubusercontent.com/xunit/assert.xunit/f1d3aeb9999a7c64a1bd7b3f513dbba6f76beba7/*",
    "/_/Biohazrd/#Declarations/*": "https://raw.githubusercontent.com/MochiLibraries/Biohazrd/f888ef20336e649f9cbc1fe0aeb4aae6b29d70db/Biohazrd/%23Declarations/*"
  }
}

However I'd definitely rather not deal with that.

(Thanks to @js6pak for bringing this to my attention.)

@PathogenDavid PathogenDavid added the External Issues which represent work which affects Biohazrd but needs to happen outside of Biohazrd label Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
External Issues which represent work which affects Biohazrd but needs to happen outside of Biohazrd
Projects
None yet
Development

No branches or pull requests

1 participant