Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Inconsistencies in colors #189

Open
sand4rt opened this issue Apr 20, 2024 · 1 comment
Open

[Bug] Inconsistencies in colors #189

sand4rt opened this issue Apr 20, 2024 · 1 comment

Comments

@sand4rt
Copy link
Contributor

sand4rt commented Apr 20, 2024

VScode:
Screenshot 2024-04-20 at 15 38 16

VScode.nvim
Screenshot 2024-04-20 at 15 40 23

@johannesrld
Copy link
Contributor

johannesrld commented May 5, 2024

I can see about fixing TSX Tags, however there are some issues simply due to how Treesitters JavaScript highlights are set up, for example

Highlighting type in import type would require a custom Treesitter query, this is easy but I don't really like the idea (plus Treesitter is also more accurate at highlighting the types imported by import type than VS Code, there its highlighted as a variable whilst in vscode.nvim its correctly highlighted the same colour as other types).

both the async keyword and the await keyword are captured in the highlight group @keyword.coroutine. This should probably be set to the same pinkish colour that other control flow keywords are set to like return and if but that would highlight async and await as pink, not just await, which would still be inconsistent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants