Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Since commit 6ec399, terminal color are lighter then before #201

Open
wenjinnn opened this issue May 21, 2024 · 4 comments
Open

Since commit 6ec399, terminal color are lighter then before #201

wenjinnn opened this issue May 21, 2024 · 4 comments

Comments

@wenjinnn
Copy link
Contributor

Hi there.
This commit add a terminal_color = true as a default config value, before I upgrade to this commit, my terminal looks like:
image
after:
image
I think we should consider about this, Is it need to be true as default? and may be add some doc about this new config value, because it took me some time to figure out that is was this config caused these effects.

@Mofiqul
Copy link
Owner

Mofiqul commented May 22, 2024

@wenjinnn, @xyven1 - Keeping it true as default is what I would prefer. We need to add it to the README.

@xyven1
Copy link
Contributor

xyven1 commented May 22, 2024

Hey, I can also fix it as I mentioned in the PR by using the colors defined in the terminal extensions, which will make the colors brighter again.

Since I think (correct me if I'm wrong) the main goal of this plugin is to provide a color scheme which replicates vscode colors as close as possible, using the colors defined in the terminal extensions would better accomplish that task. I'm happy to make that fix, add some documentation to the README and pr that @Mofiqul.

@wenjinnn
Copy link
Contributor Author

Hi, thanks for reply, I just read the PR comment. Personally, I prefer neovim internal terminals to keep the same color as the normal terminal, cuz I customized terminal color like vscode by myself. but other people might like this feature, so I think nothing wrong about this, just add some documentation will be nice.

@Mofiqul
Copy link
Owner

Mofiqul commented May 24, 2024

Hey, I can also fix it as I mentioned in the PR by using the colors defined in the terminal extensions, which will make the colors brighter again.

Since I think (correct me if I'm wrong) the main goal of this plugin is to provide a color scheme which replicates vscode colors as close as possible, using the colors defined in the terminal extensions would better accomplish that task. I'm happy to make that fix, add some documentation to the README and pr that @Mofiqul.

Let's go with as it is by mentioning in Readme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants