Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -S to git commit command in CONTRIBUTING.md #278

Open
emanuelb opened this issue Aug 11, 2020 · 2 comments
Open

Add -S to git commit command in CONTRIBUTING.md #278

emanuelb opened this issue Aug 11, 2020 · 2 comments

Comments

@emanuelb
Copy link

FROM CONTRIBUTING.md

3. Commit a failing test for the bug:

`git commit -am "Adds a failing test to demonstrate that thing"`

4. Commit a fix that makes the test pass:

`git commit -am "Adds a fix for that thing!"`

add -S to above commands, in order to apply signing, see issue #237

@kaplanlior
Copy link
Member

What's the need to sign every commit ? Especially when most of them comes from the dev team contracted to work on the project.

#238 should be enough in case you want to verify things for the long run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants