From b64c99cd4ae33108b0bce5589de4876f209a61c1 Mon Sep 17 00:00:00 2001 From: MohamedRaslan Date: Wed, 10 Jul 2024 14:09:15 +0300 Subject: [PATCH] Fix linter errors --- .github/workflows/ci.yml | 3 +-- README.md | 22 +++++++++++----------- __tests__/build/app1/index.html | 17 ++++++++++------- __tests__/build/app2/index.html | 17 ++++++++++------- __tests__/build/app3/index.html | 17 ++++++++++------- script/release | 0 6 files changed, 42 insertions(+), 34 deletions(-) mode change 100644 => 100755 script/release diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 97f4c2e..617eea2 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -69,7 +69,6 @@ jobs: uses: ./ with: start: yarn fake-servers - wait-on: - 'http://localhost:4001, http://localhost:4002, http://localhost:4003' + wait-on: 'http://localhost:4001,http://localhost:4002,http://localhost:4003' wait-on-timeout: 10 command: yarn lint diff --git a/README.md b/README.md index fefbeed..af570a6 100644 --- a/README.md +++ b/README.md @@ -1,3 +1,5 @@ +# Background Run & Test GitHub Action + [![Lint Codebase](https://github.com/MohamedRaslan/backgrond_run_and_test/actions/workflows/linter.yml/badge.svg)](https://github.com/MohamedRaslan/backgrond_run_and_test/actions/workflows/linter.yml) [![Dependabot Updates](https://github.com/MohamedRaslan/backgrond_run_and_test/actions/workflows/dependabot/dependabot-updates/badge.svg)](https://github.com/MohamedRaslan/backgrond_run_and_test/actions/workflows/dependabot/dependabot-updates) @@ -16,12 +18,10 @@ [![GitHub Release Date](https://img.shields.io/github/release-date/mohamedraslan/backgrond_run_and_test)](https://github.com/MohamedRaslan/backgrond_run_and_test/releases) [![GitHub code size in bytes](https://img.shields.io/github/languages/code-size/mohamedraslan/backgrond_run_and_test)](https://github.com/MohamedRaslan/backgrond_run_and_test) -# Background Run & Test GitHub Action - GitHub Action to run a commands (e.g. a test) while also running another commands (e.g. a server) in the background, And you could conditional wait for the background resources to be available the `wait-on` use the -**[wait-on](https://www.yarnjs.com/package/wait-on)** yarn package under the +**[wait-on](https://www.yarnjs.com/package/wait-on)** Yarn package under the hood so most of the `waiton` functionality should be accepted. > :information_source: **Notice** @@ -41,14 +41,14 @@ hood so most of the `waiton` functionality should be accepted. - Optionally wait for resources before running your test, your resources could be (files, ports, sockets, or http(s) resources to become available (or not available using reverse mode)) as it use the - **[wait-on](https://www.yarnjs.com/package/wait-on)** yarn package under the + **[wait-on](https://www.yarnjs.com/package/wait-on)** Yarn package under the hood - Conditional wait using the `wait-if` option - You can run multiple commands at once ### Usage -Run a node js server in the background while executing tests +Run a Nodejs server in the background while executing tests ```yaml name: Run Tests @@ -134,7 +134,7 @@ jobs: ### Wait for server If you are starting a local server and it takes a while to start, you can add a -parameter `wait-on` and pass url to wait for the server to respond. +parameter `wait-on` and pass URL to wait for the server to respond. ```yaml name: Run Tests @@ -166,7 +166,7 @@ seconds using `wait-on-timeout`. command: yarn run test:apps ``` -You can wait for multiple URLs to respond by separating urls with a comma +You can wait for multiple URLs to respond by separating URLs with a comma ```yaml - uses: MohamedRaslan/backgrond_run_and_test@v1 @@ -228,10 +228,10 @@ Contributions are very welcome :heart:. ## :nerd_face: Credits & Resources -- **[Wait-on :heart_eyes:](https://github.com/jeffbski/wait-on)** by +- **[wait-on :heart_eyes:](https://github.com/jeffbski/wait-on)** by **[Jeff Barczewski](https://github.com/jeffbski)** -- **[Cypress-io/Github-Action :heart_eyes:](https://github.com/cypress-io/github-action)** -- **[Background-Server-Action :heart_eyes:](https://github.com/MohamedRaslan/backgrond_run_and_test)** +- **[cypress-io/github-action :heart_eyes:](https://github.com/cypress-io/github-action)** +- **[background-server-action :heart_eyes:](https://github.com/MohamedRaslan/backgrond_run_and_test)** by **[Bernhard Wittmann](https://github.com/BerniWittmann)** - **[GitHub Docs - Createing Actions](https://docs.github.com/en/actions/creating-actions)** -- **[Actions/Typescript-Action](actions/typescript-action)** +- **[actions/typescript-action](actions/typescript-action)** diff --git a/__tests__/build/app1/index.html b/__tests__/build/app1/index.html index 7aabebf..1232084 100644 --- a/__tests__/build/app1/index.html +++ b/__tests__/build/app1/index.html @@ -1,8 +1,11 @@ - - - Example of App 1 - - -

Example of App 1

- + + + + + Example of App 1 + + +

Example of App 1

+ + diff --git a/__tests__/build/app2/index.html b/__tests__/build/app2/index.html index 0a25a97..9f31405 100644 --- a/__tests__/build/app2/index.html +++ b/__tests__/build/app2/index.html @@ -1,8 +1,11 @@ - - - Example of App 2 - - -

Example of App 2

- + + + + + Example of App 2 + + +

Example of App 2

+ + diff --git a/__tests__/build/app3/index.html b/__tests__/build/app3/index.html index 45b0da0..824afe7 100644 --- a/__tests__/build/app3/index.html +++ b/__tests__/build/app3/index.html @@ -1,8 +1,11 @@ - - - Example of App 3 - - -

Example of App 3

- + + + + + Example of App 3 + + +

Example of App 3

+ + diff --git a/script/release b/script/release old mode 100644 new mode 100755