Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: about page component #38

Merged
merged 3 commits into from
Dec 24, 2023
Merged

fix: about page component #38

merged 3 commits into from
Dec 24, 2023

Conversation

AaadityaG
Copy link
Contributor

@AaadityaG AaadityaG commented Dec 24, 2023 •
edited
Loading

Close #29

SheEARNS — Mozilla Firefox 24-12-2023 12_27_50 PM

@vercel Vercel
Copy link

vercel bot commented Dec 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
she-earns ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2023 8:06am

@AaadityaG
Copy link
Contributor Author

@MonalikaPatnaik Its done, please considr for codepeak points

@MonalikaPatnaik
Copy link
Owner

Thankyou..looking good to me. Just pull the changes in your branch by using git pull and add the About element in the navbar here.
image

@AaadityaG
Copy link
Contributor Author

Should I raise a new PR?

@MonalikaPatnaik
Copy link
Owner

Should I raise a new PR?

No, push commits to this PR only.

@AaadityaG
Copy link
Contributor Author

How can I pull main branch uptodate with aboutpage branch

@AaadityaG
Copy link
Contributor Author

Ok I got it
Also Small Update I did like below

SheEARNS — Mozilla Firefox 24-12-2023 01_26_35 PM

Isn't it more appealing

@MonalikaPatnaik
Copy link
Owner

first switch to your feature branch by using git checkout aboutpage command in your terminal.
then try using the command git pull origin main to pull the changes.

@MonalikaPatnaik
Copy link
Owner

Ok I got it Also Small Update I did like below

SheEARNS — Mozilla Firefox 24-12-2023 01_26_35 PM

Isn't it more appealing

yes. looking good <3

@AaadityaG
Copy link
Contributor Author

AaadityaG commented Dec 24, 2023 •
edited
Loading

Finally Its done... I think..😅

@MonalikaPatnaik MonalikaPatnaik merged commit e2c6110 into MonalikaPatnaik:main Dec 24, 2023
1 check passed
@AaadityaG AaadityaG deleted the aboutpage branch December 24, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: About Page
2 participants
@AaadityaG @MonalikaPatnaik