Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anti-drop doesn't anti-drop #3502

Closed
Kmla2 opened this issue Sep 21, 2024 · 2 comments
Closed

anti-drop doesn't anti-drop #3502

Kmla2 opened this issue Sep 21, 2024 · 2 comments
Labels
bug Something isn't working Major

Comments

@Kmla2
Copy link
Collaborator

Kmla2 commented Sep 21, 2024

Round ID: 6941, doesn't matter at all

Testmerges:

[#1797: 'Adds Power gloves as a new engineering traitor item!' by F-e-r-n at commit e6140ec](https://github.com//pull/1797) [#2655: '[DNM] Plexora' by flleeppyy at commit 7b4319d](https://github.com//pull/2655) [#3139: 'Theseus' by t-toasted at commit 42ebfbd](https://github.com//pull/3139) [#2711: 'Bomb-Actualizer' by ThePooba at commit 9a9319a](https://github.com//pull/2711) [#3278: 'Replaces rigged storyteller with automatic transfer votes' by Absolucy at commit b65288f](https://github.com//pull/3278) [#3301: 'A singular cooking recipe, and an overhaul of blood, temperature, and pain.' by dwasint at commit 34d1c30](https://github.com//pull/3301) [#3392: 'Signboards!' by Absolucy at commit cb8bd3d](https://github.com//pull/3392) [#3413: 'Reverts mood change indicators' by Absolucy at commit 97ee988793](https://github.com//pull/3413) [#3303: 'Its time to go to heaven my child (Divine Warning)' by flleeppyy at commit a58af80](https://github.com//pull/3303) [#3367: '[PORTS] Ports portable gravity generator, main gravgen repair text, fixes gravity fields' by PotatoTomahto at commit e493e6e](https://github.com//pull/3367) [#3246: 'Tunnel Vision Quirk' by Noot-Toot at commit 9b03532](https://github.com//pull/3246) [#3453: '[DNM] oh god fix this lag asap' by Absolucy at commit 1fd35c4](https://github.com//pull/3453) [#3477: 'Remove snowflake conversion immunities' by RikuTheKiller at commit 8eee290](https://github.com//pull/3477) [#3481: 'Antag selection weighting fixups' by Absolucy at commit fe6d53c](https://github.com//pull/3481)

Reproduction:

  1. Get an anti drop implants along with its cyberlink
  2. Activate it with something like an energy sword or really any item
  3. Go into crit / slip on liquid (probally on anything)
  4. It drops out of your hands, pick it up, try to activate implant. doesn't work, gives no message, complete silent and non working
  5. Congratulations, you have given things to an enemy that shouldn't have been given

Edit, need to check if the message the first time even shows up, though even if it doesn't this is still a bug in theory as it would say that the cyberlink is not compatible when activating

@ThePooba ThePooba added bug Something isn't working Major labels Sep 23, 2024
@Kmla2
Copy link
Collaborator Author

Kmla2 commented Sep 23, 2024

gonna need to be tested when #3520 is merged though as i WAS an assault op at that time

@Gw0sty
Copy link
Collaborator

Gw0sty commented Dec 10, 2024

To my testing this issue is now fixed.

@Gw0sty Gw0sty closed this as completed Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Major
Projects
None yet
Development

No branches or pull requests

3 participants