Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All /element/shoesteps noisemakers are quantumly entangled #5365

Closed
MonkestationIssueBot opened this issue Feb 8, 2025 · 0 comments · Fixed by #5388
Closed

All /element/shoesteps noisemakers are quantumly entangled #5365

MonkestationIssueBot opened this issue Feb 8, 2025 · 0 comments · Fixed by #5388

Comments

@MonkestationIssueBot
Copy link

MonkestationIssueBot commented Feb 8, 2025 •
edited by github-actions bot
Loading

Reporting client info: Client Information:
BYOND:515.1642
Key:tractormann

Round ID:

9302

Testmerges:

Reproduction:

(not created this round, just here for recordkeeping purposes plus i forgor to do it on the round i DID figure it out.)

Basically all noisemakers are quantumly entangled, if you activate the shoesteps on one pair of jackboots, ALL jackboots get the step sounds. Identical for turning off too. Probably due to some issue with not making them unique instances properly, but my ass hasnt figured out how to fix that Yet(TM). Goddamnit.
@Coll6 Coll6 mentioned this issue Feb 9, 2025
Merged
Absolucy pushed a commit that referenced this issue Feb 9, 2025
@Coll6
Custom Shoe Sounds fix. (#5388)
ca87102 
## About The Pull Request

Elements and components aren't easily explained. I made an oops thinking
I could make this an element. Caused anything using this element to
share the same settings. This changes it to a component and fixes this
"quantum locking" issue.

Fixes #5365

## Why It's Good For The Game

Shoe sounds are supposed to be instanced on each shoe its applied to not
shared between each shoe. Defeats the purpose of custom shoe sounds.
This refactor fixes it.

## Changelog
:cl: Siro
fix: Fixed all jackboots being quantum entangled - toggling the
noisemaker for one pair of jackboots no longer changes it for every
other pair of jackboots too.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Custom Shoe Sounds fix. Coll6/Monkestation2.0
1 participant
@MonkestationIssueBot