Personal AI download menu NTOS, gamespace blacked out entirely

[MonkestationIssueBot]

Reporting client info: Client Information:
BYOND:514.1589
Key:dexee

Round ID:

2525

Testmerges:

• [DRAFT] Art-Sci redux, monkecode edition
• Minecraft nether update real
• Storyteller rebalance and modularization. (And two more storytellers)
• Stuff Goon People Talked about wanting
• thousand yard stare

Reproduction:

When spawning as a pAI, you cannot see anything. You also get the following NTOS error when opening the DOWNLOADS menu on the pai software interface:

A fatal exception has occurred at 002B:C562F1B7 in TGUI. The current application will be terminated. Send the copy of the following stack trace to an authorized Nanotrasen incident handler at https://github.com/tgstation/tgstation. Thank you for your cooperation.
TypeError: Unable to get property 'includes' of undefined or null reference
at d (http://127.0.0.1:50057/tmp11272/tgui.bundle.js:1:1436253)
at De (http://127.0.0.1:50057/tmp11272/tgui.bundle.js:1:180766)
at Anonymous function (http://127.0.0.1:50057/tmp11272/tgui.bundle.js:1:181145)
at Ee (http://127.0.0.1:50057/tmp11272/tgui.bundle.js:1:181061)
at Re (http://127.0.0.1:50057/tmp11272/tgui.bundle.js:1:182193)
at Oe (http://127.0.0.1:50057/tmp11272/tgui.bundle.js:1:182026)
at Ee (http://127.0.0.1:50057/tmp11272/tgui.bundle.js:1:180878)
at Oe (http://127.0.0.1:50057/tmp11272/tgui.bundle.js:1:181990)
at Ee (http://127.0.0.1:50057/tmp11272/tgui.bundle.js:1:180878)
at Anonymous function (http://127.0.0.1:50057/tmp11272/tgui.bundle.js:1:181145)
User Agent: Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 6.2; WOW64; Trident/7.0; .NET4.0C; .NET4.0E; .NET CLR 2.0.50727; .NET CLR 3.0.30729; .NET CLR 3.5.30729)
State: {"ckey":"dexee","interface":"PaiInterface","window":{"key":"[mob_4616]-main","size":null,"fancy":1,"locked":0}}

[DexeeXI]

One runtime detected thus far.

[15:44:19] Runtime in code/modules/pai/software.dm, line 11: Cannot read null.emotion_icon
proc name: ui data (/mob/living/silicon/pai/ui_data)
usr: goombo/(Bepis)
usr.loc: (Research Director's Office (115,93,2))
src: Bepis (/mob/living/silicon/pai)
src.loc: the personal AI device (/obj/item/pai_card)
call stack:
Bepis (/mob/living/silicon/pai): ui data(Bepis (/mob/living/silicon/pai))
/datum/tgui (/datum/tgui): get payload(null, 1, 1)
/datum/tgui (/datum/tgui): open()
Bepis (/mob/living/silicon/pai): ui interact(Bepis (/mob/living/silicon/pai), /datum/tgui (/datum/tgui))
Software Interface (/atom/movable/screen/pai/software): Click(null, "mapwindow.map", "icon-x=15;icon-y=12;left=1;but...")
Goombo (/client): Click(Software Interface (/atom/movable/screen/pai/software), null, "mapwindow.map", "icon-x=15;icon-y=12;left=1;but...")

[DexeeXI]

Another runtime

[15:57:04] Runtime in code/modules/pai/software.dm, line 11: Cannot read null.emotion_icon
proc name: ui data (/mob/living/silicon/pai/ui_data)
usr: goombo/(Bepis)
usr.loc: (Robotics Lab (125,116,2))
src: Bepis (/mob/living/silicon/pai)
src.loc: the personal AI device (/obj/item/pai_card)
call stack:
Bepis (/mob/living/silicon/pai): ui data(Bepis (/mob/living/silicon/pai))
/datum/tgui (/datum/tgui): get payload(null, 1, 1)
/datum/tgui (/datum/tgui): open()
Bepis (/mob/living/silicon/pai): ui interact(Bepis (/mob/living/silicon/pai), /datum/tgui (/datum/tgui))
Software Interface (/atom/movable/screen/pai/software): Click(null, "mapwindow.map", "icon-x=16;icon-y=29;left=1;but...")

[DexeeXI]

[15:57:09] Runtime in code/modules/pai/software.dm, line 144: Cannot modify null.emotion_icon.
proc name: change image (/mob/living/silicon/pai/proc/change_image)
usr: goombo/(Bepis)
usr.loc: (Robotics Lab (125,116,2))
src: Bepis (/mob/living/silicon/pai)
src.loc: the personal AI device (/obj/item/pai_card)
call stack:
Bepis (/mob/living/silicon/pai): change image()
Bepis (/mob/living/silicon/pai): ui act("change image", /list (/list), /datum/tgui (/datum/tgui), /datum/ui_state/default (/datum/ui_state/default))
/datum/tgui (/datum/tgui): on act message("change image", /list (/list), /datum/ui_state/default (/datum/ui_state/default))
/datum/callback/verb_callback (/datum/callback/verb_callback): InvokeAsync()

[DexeeXI]

[15:59:16] Runtime in code/modules/pai/shell.dm, line 128: Cannot read null.loc
proc name: fold out (/mob/living/silicon/pai/proc/fold_out)
usr: StrangeSpectre/(57R4WB3RRY)
usr.loc: (Kitchen (122,162,2))
src: 57R4WB3RRY (/mob/living/silicon/pai)
src.loc: the personal AI device (/obj/item/pai_card)
call stack:
57R4WB3RRY (/mob/living/silicon/pai): fold out(0)
Toggle Holoform (/atom/movable/screen/pai/shell): Click(null, "mapwindow.map", "icon-x=17;icon-y=23;left=1;but...")
StrangeSpectre (/client): Click(Toggle Holoform (/atom/movable/screen/pai/shell), null, "mapwindow.map", "icon-x=17;icon-y=23;left=1;but...")

[DexeeXI]

[15:59:55] Runtime in code/modules/pai/software.dm, line 11: Cannot read null.emotion_icon
proc name: ui data (/mob/living/silicon/pai/ui_data)
usr: StrangeSpectre/(57R4WB3RRY)
usr.loc: (Kitchen (122,162,2))
src: 57R4WB3RRY (/mob/living/silicon/pai)
src.loc: the personal AI device (/obj/item/pai_card)
call stack:
57R4WB3RRY (/mob/living/silicon/pai): ui data(57R4WB3RRY (/mob/living/silicon/pai))
/datum/tgui (/datum/tgui): get payload(null, 1, 1)
/datum/tgui (/datum/tgui): open()
57R4WB3RRY (/mob/living/silicon/pai): ui interact(57R4WB3RRY (/mob/living/silicon/pai), /datum/tgui (/datum/tgui))
Software Interface (/atom/movable/screen/pai/software): Click(null, "mapwindow.map", "icon-x=22;icon-y=21;left=1;but...")

[DexeeXI]

[16:02:35] Runtime in code/modules/pai/software.dm, line 11: Cannot read null.emotion_icon
proc name: ui data (/mob/living/silicon/pai/ui_data)
usr: StrangeSpectre/(57R4WB3RRY)
usr.loc: (Kitchen (123,158,2))
src: 57R4WB3RRY (/mob/living/silicon/pai)
src.loc: the personal AI device (/obj/item/pai_card)
call stack:
57R4WB3RRY (/mob/living/silicon/pai): ui data(57R4WB3RRY (/mob/living/silicon/pai))
/datum/tgui (/datum/tgui): get payload(null, 1, 1)
/datum/tgui (/datum/tgui): open()
57R4WB3RRY (/mob/living/silicon/pai): ui interact(57R4WB3RRY (/mob/living/silicon/pai), /datum/tgui (/datum/tgui))
Software Interface (/atom/movable/screen/pai/software): Click(null, "mapwindow.map", "icon-x=23;icon-y=18;left=1;but...")

[DexeeXI]

[16:07:50] Runtime in code/modules/pai/shell.dm, line 128: Cannot read null.loc
proc name: fold out (/mob/living/silicon/pai/proc/fold_out)
usr: Soren54/(Bard)
usr.loc: (Research Firing Range (114,86,2))
src: Bard (/mob/living/silicon/pai)
src.loc: the personal AI device (/obj/item/pai_card)
call stack:
Bard (/mob/living/silicon/pai): fold out(0)
Toggle Holoform (/atom/movable/screen/pai/shell): Click(null, "mapwindow.map", "icon-x=24;icon-y=21;left=1;but...")
Soren54 (/client): Click(Toggle Holoform (/atom/movable/screen/pai/shell), null, "mapwindow.map", "icon-x=24;icon-y=21;left=1;but...")

[DexeeXI]

[16:08:54] Runtime in code/modules/pai/software.dm, line 144: Cannot modify null.emotion_icon.
proc name: change image (/mob/living/silicon/pai/proc/change_image)
usr: Soren54/(Bard)
usr.loc: (Research Firing Range (114,86,2))
src: Bard (/mob/living/silicon/pai)
src.loc: the personal AI device (/obj/item/pai_card)
call stack:
Bard (/mob/living/silicon/pai): change image()
Bard (/mob/living/silicon/pai): ui act("change image", /list (/list), /datum/tgui (/datum/tgui), /datum/ui_state/default (/datum/ui_state/default))
/datum/tgui (/datum/tgui): on act message("change image", /list (/list), /datum/ui_state/default (/datum/ui_state/default))
/datum/callback/verb_callback (/datum/callback/verb_callback): InvokeAsync()

[DexeeXI]

[16:10:43] Runtime in code/modules/pai/software.dm, line 11: Cannot read null.emotion_icon
proc name: ui data (/mob/living/silicon/pai/ui_data)
usr: Soren54/(Bard)
usr.loc: (Research Firing Range (115,87,2))
src: Bard (/mob/living/silicon/pai)
src.loc: the personal AI device (/obj/item/pai_card)
call stack:
Bard (/mob/living/silicon/pai): ui data(Bard (/mob/living/silicon/pai))
/datum/tgui (/datum/tgui): get payload(null, 1, 1)
/datum/tgui (/datum/tgui): open()
Bard (/mob/living/silicon/pai): ui interact(Bard (/mob/living/silicon/pai), /datum/tgui (/datum/tgui))
Software Interface (/atom/movable/screen/pai/software): Click(null, "mapwindow.map", "icon-x=13;icon-y=26;left=1;but...")
Software Interface (/atom/movable/screen/pai/software): Click(null, "mapwindow.map", "icon-x=13;icon-y=26;left=1;but...")
/datum/callback/verb_callback (/datum/callback/verb_callback): Invoke()
world: push usr(Bard (/mob/living/silicon/pai), /datum/callback/verb_callback (/datum/callback/verb_callback))
/datum/callback/verb_callback (/datum/callback/verb_callback): InvokeAsync()
Input (/datum/controller/subsystem/verb_manager/input): run verb queue()
Input (/datum/controller/subsystem/verb_manager/input): fire(0)
Input (/datum/controller/subsystem/verb_manager/input): fire(0)
Input (/datum/controller/subsystem/verb_manager/input): fire(0)
Input (/datum/controller/subsystem/verb_manager/input): ignite(0)
Master (/datum/controller/master): RunQueue()
Master (/datum/controller/master): Loop(2)
Master (/datum/controller/master): StartProcessing(0)

[DexeeXI]

Root cause identified and correct. Cause: TG coders being TG coders, deleted a line that was needed to set the PAI to the device.