Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyborg Expansion Module fails to EXPAND as intended #592

Closed
DexeeXI opened this issue Nov 22, 2023 · 1 comment
Closed

Cyborg Expansion Module fails to EXPAND as intended #592

DexeeXI opened this issue Nov 22, 2023 · 1 comment

Comments

@DexeeXI
Copy link
Collaborator

DexeeXI commented Nov 22, 2023

Round ID:

Most recent, 2569

Testmerges:

#505, #537, #549, #578, #489

Reproduction:

  1. Acquire cyborg of any flavor
  2. Install EXPANSION module
  3. Observe that the cyborg does not, in fact, expand by a factor of two.
  4. Reset cyborg
  5. Observe that the cyborg has, in fact, shrunk by a factor of 0.5.

Additional Notes:

It appears that this issue is derrived from when we had implemented tgstation#78146 in when they had refactored the transform. It seems to touch an awful lot of different files in order to affect this refactoring of code. There may or may not be a fix PR up on TG at the time of this writing, but I am only investigating issues and attempting to determine the root causes and move on.

@DexeeXI
Copy link
Collaborator Author

DexeeXI commented Nov 29, 2023

Fixed with #624

@DexeeXI DexeeXI closed this as completed Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant