Synchronize with sylius #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nhez, kulczy, AdamKasp, SirDomin) This PR was merged into the 1.9-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Related tickets | #12000 This is just the next step to improve attributes. There is still a lot to be done. ### Sort/group attributes by attribute code. There is a bug in the attributes sorting. Empty attributes are displayed at the end of the list. Also, all of the attributes are in one list, and because of that, I can't visually easily group them. So I need some help from the backend side, or maybe creating a twig helper will be a better solution? <img width="1195" alt="Zrzut ekranu 2020-11-27 o 13 05 44" src="https://user-images.githubusercontent.com/15385420/100447671-49c62880-30b1-11eb-8c69-378392690e31.png"> ### Label translation Only attributes that are displayed after loading the page have translations. Dynamically added attributes have labels in the default language. Maybe variables with translations already exist, but I haven't found it. ### Untranslatable attributes Currently, values for every language are pass to the view even if the attribute is untranslatable. Only one value has to be passed. ### Main value Every attribute has one required value, and I need it to be marked somehow. This will allow informing a user (by displaying *) that this field is required. Small but significant UX improvement. ### Untranslatable attributes are visible in global section in product view  Commits ------- f18df67e1235e34aa760a8ddd7c7dbb95f06b7fb Add getAttributesJsonAction 734f4f66ee1a7ab7cdece9b3d16f04fa916cadba Add getNameByLocaleCode method on ProductAttribute a96ac0c717e5ddaa2fc57e9b3024fd832c08bbd1 Add translatable flag on attribute 665bac744717d2d3d46224eefccd4e484af1e1bd Add toogle on admin attribute crud c9f6506b493282cf8ed751b182281fc5bc4d1a86 Attributes view reorganization 22297c175d5a6a55bfb7cc01ffece02f0a96c059 [Attributes] refactor non translatable attributes 42eb81969d15d5017cf0ce7be42ec60d05a92f7a [Attributes] remove redundant route 1b0243d8f8a22d353d4e0ed81826e200c5d7c2f0 Improve new attributes UI db3f0b7e34845d648998dd976e46739d56a3ae24 [Behats] non-translatable attributes + behats refactor 92e03236a837d574168a94fd0dc4e44df5abe780 [Behats] attributes fixes 04c75f2db72e33cf0ab6994c3bc3ca8dbe91088c [Behat] pr-fix 24b38a065dde34dba99cd9bcfdf8baa69ee523ac [Behat] add translation behat 7b2239961d26d54d70576604c935d26613a4c598 [Behat] viewing-non-translatable step f01511b5c98a2dc8a3c0ccd941ed75053a8d2f14 [UI][Admin] fix non translatable attributes on show product ac02a393aaf804351133812fc01f19249a276c81 [Behat] add step admin show product a0e1fe2bbf1be80d30c6b02f44ec0334b7bf0396 [Ui] add required display 2c01a710a8ca18d32c0994ee4e438ec4c58aa66a pr-fix 98033ca4fed27eb74c710992086a2014d58e5f89 remove tests with multiple attributes 28641e94f923657ca7d98b097f3fbe278030cad6 [Behat] fix-failing-build
This PR was merged into the 1.9-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | License | MIT <!-- - Bug fixes must be submitted against the 1.7 or 1.8 branch (the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- a37c902b1abba6e1d22ff3b5b7358df37ff9a7ef Add proper date
* 1.8: Change application's version to v1.8.11-DEV Change application's version to v1.8.10 Generate changelog for v1.8.10 [AttributeBundle] custom locale_code fixed Add tests for path delimiter while getting taxon's fullname Fix test case for default and custom taxon path delimiter Pass path delimiter up to parent Removing hard timeout on edit while load selected values
* 1.9: Change application's version to v1.9.2-DEV Change application's version to v1.9.1 Generate changelog for v1.9.1 Change application's version to v1.8.11-DEV Change application's version to v1.8.10 Generate changelog for v1.8.10 [ApiBundle] Fix displaying testing section in README file [AttributeBundle] custom locale_code fixed Add tests for path delimiter while getting taxon's fullname Fix test case for default and custom taxon path delimiter Pass path delimiter up to parent Removing hard timeout on edit while load selected values
* 1.10: PHP 7.4 syntax in bundles vol.1
…hrusciel) This PR was merged into the 1.11-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT Based on: Sylius/Sylius#13266 <!-- - Bug fixes must be submitted against the 1.9 or 1.10 branch (the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 510960bcbb84187b989ccce30bf1c2b279e4c514 [Behat] add behat scenarios to cover cases 5e2014b98ae7e6435860edb9a2c31bcd7b1a6aa5 apply cart promotions based on minimum price 8e6afc0876c723fbe6cc83b1640716fdc700769d [Behat] add more specific behats 85521518c68b9d6fade18efb86bc39a177455c47 split promotion amounts b50ec029cfc0fd4723b5e5b66a7a6b2227aeb316 [Behat] merge scenarios 44baa053cc7ec4db68a8a1d2dbd1077cbf363b4f [Behat] add more specific behats with distribution 9d25e52aa95930bba7366182483d53d93f6ac512 [Spec] fix spec, add 0 default value in migration c594ae328f324f3af2b65cdbfd5ac3d4daedfdb8 add default option to doctrine 1dae4ddc173929880478c4c6e69239a20c381f58 remove reference from distributeWithMinimumPrice 4cf2f278c0184d4c729127e83dc96d3fa94b7813 [MinimumPrice] redistribute evenly after handling minimum price d064dd0951d7d7493e9be2b436f4d6eb6a10894e [MinimumPrice] Distribute recursively after applying minimum price 2fb1f8997f5d8bdd838ecaf63b02f80e1a3b3a39 [Promotion] Minimum price distributor initial implementation 0ee76a5490e8f6eef705dc31feca7009d865500c [MinimumPrice] clean existing classess, add percentage support adaa2fe098535485fdb4e22cc427b448a7c9b8da [Behat] move reduntant steps to private methods 5a5021f35e2db1ab8b48578ef6c096f9779f0279 [UPGRADE] add info to upgrade file 05916eeee1e98d6e2cdc074fcef83820a980c261 [Spec] fix steps for latest changes 5a6c9d09c0041633651fd5586470d9dfde837c70 [BC] keep previous services implementation in Commands
* 1.10: Use phpspec ^7.1 and avoid custom error reporting level in its configuration
Introduce arrow functions from PHP 7.4
* 1.10: Class name typo Introduce arrow functions from PHP 7.4 [CI] Extract PHPSpec build Remove duplications in test_cached config
…ylius.org) This PR was merged into the 1.12-dev branch. Discussion ---------- Commits ------- a31e35b84b4d0c05a4c3ae585eccc853bf4f2412 [Translations] Updated translations from Crowdin
* 1.11: [Maintenance] Execute PHPUnit only if its config exists [Maintenance] Bring default placement of bin files severd by vendors [Maintenance] Add packages.yml to the whitelisted paths for which it should be triggered [Maintenance] Replace `test-package.sh` with native GH Actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.