Revert "Delete _maps/_mod_celadon/shuttles/syndicate/syndicate_eligia.dmm" #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrCat15352
pushed a commit
that referenced
this pull request
Dec 27, 2024
…emap Expansion #5 (shiptest-ss13#3627) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request This removes a substantial amount of bullshit from atmospherics, like the 3 made up gases that only served for powergaming purposes. This PR instead replaces them with much more fitting IRL gases seen in irl planets such as: - Argon - Carbon Monoxide - Sulfur Dioxide - Ammonia - Metane - Ozone Argon in particular inherits the fire suppression behavior from noble gas, HOWEVER, the threshold to stop reactions has been increased from 10 mols to 75 mols. this should pose an suffocation hazard The values to atmos fires have been tweaked, some gases that had no entaphy now have it This PR also adds a very basic chemical odor system, to detect certain gases based on smell, in case you don't have an atmos analyzer on you, and also to get you to actually siphon trace amounts of gases because they stink up the place in case of a breach ## Why It's Good For The Game removes cruft, replaces it with actual, fun, non-powergamey stuff that will be used soon:tm: and also has the potential to have a bunch of fun and realistic interactions when someone more familiar with this stuff than me codes it. For example outside of planetary gases, some ideas I had were: - Sparks creating ozone - Ammonia and chlorine mixing creating "snow" (Ammonium chloride) so a leak of both gases would cover the floor with snow, this sounds like a fun reaction to scare the shit out of people - smarter people like @Thera-Pissed would probably know more what to do ## Changelog :cl: add: You can now detect certain gases from smell, most notably plasma add: Adds 6 new gases, all unused at the moment del: 3 gases, Pluox, Nitryl, and Stimming balance: The noble gas suppresssion threshold has been increased from 10 mols to 75 mols balance: Various gases have had their enthalpy (energy released during fires) adjusted, changing the behavior of gas fires slightly. balance: Plasma is a much more potent skin/eye irritant balance: Hydrogen gas is no longer visible fix: Freon's stage one breath effects should work now, before they were tied to nitryl's amount /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Co-authored-by: retlaw34 <[email protected]> Co-authored-by: Erika Fox <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #4