Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Tokenizer won't open #182

Open
BokuNC opened this issue Nov 12, 2024 · 6 comments
Open

[Bug] Tokenizer won't open #182

BokuNC opened this issue Nov 12, 2024 · 6 comments

Comments

@BokuNC
Copy link

BokuNC commented Nov 12, 2024

Foundry V12.331
System: World of Darkness 5e v5.0.7 (Supposedly using Application v2)

None of the Tokenizer functions appear to be working, clicking of the actor picture does nothing (even with shift held down), the title bar option doesn't show up when activated. I have all permissions needed for it to work, but it doesn't.

@MrPrimate
Copy link
Owner

MrPrimate commented Nov 12, 2024

For the avatar click most (all?) other systems use the Foundry default method of having an img property of data-edit with either img or prototypeToken.texture.src set to identify the target. Other modules that rely on this core listener/property will also likely not work without adjustments.

I'm unsure why the titlebar option would not work with this implementation of the v2 sheet though (it does for D&D 5e)

@BokuNC
Copy link
Author

BokuNC commented Nov 12, 2024

Yeah, i don't really understand why it stopped working at all. I did request that they make it compatible again, but they answered that it probably stopped because of the "application v2" and that, unless it was clearly a system issue, they couldn't do much to solve it. So my hands are tied, having pretty much zero coding knowledge.

@Veilza
Copy link

Veilza commented Nov 12, 2024

My initial assumption was that since it was reported as completely broken it was just another module that hadn't been updated yet; that was actually my bad for not doing my own investigation first and now I've done some looking into this on my end to give better insight.

I will say this seems at least partly AppV2-related. But I do want to clear up the issue from @BokuNC that "clicking the actor picture does nothing" actually isn't an issue; I tested just now and Tokenizer is 100% functioning as expected within the system. So I don't know if it's a different module or anything causing that, but at the very least I can say the system's sheet isn't interfering with Tokenizer's base functionality. Edit: I actually did find an issue that would sometimes cause Tokenizer to not trigger its window. Oops! So that'll be fixed in the next system update.

The title bar option definitely isn't working though and I tested that with Into The Odd as well, one of the other systems I've found to use AppV2, so I think that actually is AppV2 related.

It's working on D&D5E because they're not actually using AppV2 yet. D&D5E's system creates a class called "ActorSheetV2" which is referring to V2 of the system sheet, not the actual ApplicationV2 framework as core Foundry calls it.

@Veilza
Copy link

Veilza commented Nov 12, 2024

Specifically for the header button not appearing: AppV2 defines header controls in _getHeaderControls() now and it doesn't seem like it'll re-add the getActorSheetHeaderButtons hook until V13, as per this issue over here: foundryvtt/foundryvtt#11668

So honestly that functionality might remain broken until V13 when that hook is re-added, since that seems like what Tokenizer uses to add its header control.

@BokuNC
Copy link
Author

BokuNC commented Nov 12, 2024

Veilza seems to have found something on the system that was causing a problem and its supposed to be fixed for the next update. This does seem to close this "issue".

Thank you all for the attention and patience!

@MrPrimate
Copy link
Owner

MrPrimate commented Nov 13, 2024

Specifically for the header button not appearing: AppV2 defines header controls in _getHeaderControls() now and it doesn't seem like it'll re-add the getActorSheetHeaderButtons hook until V13, as per this issue over here: foundryvtt/foundryvtt#11668

So honestly that functionality might remain broken until V13 when that hook is re-added, since that seems like what Tokenizer uses to add its header control.

Ah, thank you for this, i shall see if i can fix this for the current v2 header implementation then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants