Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.20.1] Lamp block halos not working on 1.20.1 #1868

Closed
guilomet opened this issue Jun 22, 2024 · 4 comments · Fixed by #1875
Closed

[1.20.1] Lamp block halos not working on 1.20.1 #1868

guilomet opened this issue Jun 22, 2024 · 4 comments · Fixed by #1875

Comments

@guilomet
Copy link

Minecraft version

1.20.x

CodeChickenLib version

4.4.0.512

CBMultipart version

3.3.0.146

ProjectRed version

4.19.0-beta+3

What happened?

When I use the colored block (inversed or not), I don't have any colored light, but only a standard light (like a torch) with some strange shaders popping sometime.

Here some screenshots (no more mods are in this instance, only the dependecies and Project Red).

2024-06-22_21 09 34
2024-06-22_21 09 45

Crash log

https://gist.github.com/guilomet/13cde5088eb655c68d9921aabf99a1f5.js

How do you make it happen again?

Just place some illuminated and colored block anywhere.

@guilomet guilomet added the bug label Jun 22, 2024
@guilomet guilomet changed the title [Bug] Colored blocks not working on 1.20.1 [1.20.1] Colored blocks not working on 1.20.1 Jun 22, 2024
@MrTJP
Copy link
Owner

MrTJP commented Jun 23, 2024

Confirmed bug with non-fabulous rendering mode. Will look into it

@MrTJP MrTJP changed the title [1.20.1] Colored blocks not working on 1.20.1 [1.20.1] Lamp block halos not working on 1.20.1 Jul 11, 2024
@MrTJP
Copy link
Owner

MrTJP commented Jul 12, 2024

This is a bug in NeoForge. It was fixed in the 1.20.x branch but has not been picked into 1.20.1. I'll see if I can open a Pull Request for it.

neoforged/NeoForge#231

@guilomet
Copy link
Author

Arf, I got the bug with Forge to, and indeed Neoforged didn't backport some fixes. But I got this problem in Forge 47.3.1.
Just to know, have you some futur compat with Oculus shaders or not ?

@MrTJP
Copy link
Owner

MrTJP commented Jul 13, 2024

Trying to throw together a mixin to path the bug at runtime.

There's no specific compatibility with Oculus shaders or any thing else. It might work though.

@MrTJP MrTJP moved this from Todo to Done in Project Red Jul 13, 2024
@github-project-automation github-project-automation bot moved this from Done to Closed in Project Red Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

2 participants