improve error log

MrWangJustToDo · Nov 10, 2023 · 8bf1bc6 · 8bf1bc6
1 parent 8f44ef6
commit 8bf1bc6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/__tests__/testHook.html b/__tests__/testHook.html
@@ -7,8 +7,11 @@
     <script src="../bundle/babel.min.js"></script>
     <!-- <script src="../bundle/react.development.js"></script> -->
     <!-- <script src="../bundle/react-dom.development.js"></script> -->
-    <script src="../packages/myreact/dist/umd/index.development.js"></script>
-    <script src="../packages/myreact-dom/dist/umd/index.development.js"></script>
+    <!-- <script src="../packages/myreact/dist/umd/index.development.js"></script> -->
+    <!-- <script src="../packages/myreact-dom/dist/umd/index.development.js"></script> -->
+    <script src="../packages/myreact/dist/umd/index.production.js"></script>
+    <script src="../packages/myreact-dom/dist/umd/index.production.js"></script>
+    <!-- <script src="../packages/myreact-dom/dist/umd/index.development.js"></script> -->
     <style>
       .red {
         color: red;
@@ -118,6 +121,8 @@
 
         console.log(val);
 
+        val % 2 === 0 ? useState() : useRef();
+
         return (
           <div>
             <Counter initialCount={val} />

diff --git a/packages/myreact-reconciler/src/renderUpdate/trigger.ts b/packages/myreact-reconciler/src/renderUpdate/trigger.ts
@@ -260,6 +260,8 @@ export const triggerError = (fiber: MyReactFiberNode, error: Error, cb?: () => v
 
       cb?.();
 
+      throw error;
+    } else {
       throw error;
     }
   }
-Original file line number
+Diff line change
@@ Expand Up @@
           cb?.();
+          throw error;
+        } else {
           throw error;
         }
       }
@@ Expand Down @@