Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break DropWizard and JDBI depdencies #6

Open
lorrin opened this issue May 1, 2013 · 0 comments
Open

Break DropWizard and JDBI depdencies #6

lorrin opened this issue May 1, 2013 · 0 comments

Comments

@lorrin
Copy link
Member

lorrin commented May 1, 2013

io.ifar.skidroad.dropwizard provides: CLI & tasks, *Managed wrappers, and config beans. Nothing outside of the package depends on anything inside it. Can just move it to a separate optional JAR. To use in Play instead, might want to add an io.ifar.skidroad.play package that provides analogous Play hooks.

io.ifar.skidroad.jdbi is similar. Can move to separate JAR, provide alternate LogFileTracker implementation. LogFileTracker is basically a sink for log file events. A file based implementation could be provided. The minimal amount of state to track is whether a file has been uploaded or not, which could be handled with file system operations rather than database. Also the dropwizard CLI uses the JDBI DAO directly to list files. This should probably be routed through the tracker to make things more modular. Postpone totally breaking dropwizard -> JDBI dependency though, since the dropwizard CLI tasks also take care of constructing the JDBI layer.

Weaving through alternate encryption would be straight-forward via PrepWorkerFactory interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant