Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added flag to disable postgresql deployment for enterprise #8

Conversation

RafaelOAiSquared
Copy link
Contributor

@RafaelOAiSquared RafaelOAiSquared commented Apr 30, 2024

Description

Added flag multiwovenPostgresql.enabled, set true by default; which can be used to disable the deployment of postgresql-related services when using a cloud-based database provider.

When setting the flag to false, the following db-related values need to be set as well:

  • multiwovenConfig.dbHost
  • multiwovenConfig.dbPassword
  • multiwovenConfig.dbPort
  • multiwovenConfig.dbUsername

Example helm command:

helm upgrade -i multiwoven . \
  --set multiwovenPostgresql.enabled=false \
  --set multiwovenConfig.dbHost=<host> \
  --set multiwovenConfig.dbPassword=<password> \
  --set multiwovenConfig.dbPort=<port> \
  --set multiwovenConfig.dbUsername=<username>

Related Issue

INFRA-22

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New Connector (Destination or Source Connector)
  • Breaking change (fix or feature that would impact existing functionality)
  • Styling change
  • Documentation update
  • Refactoring
  • Chore

How Has This Been Tested?

Using an existing kubernetes cluster, with kubectl and helm configured to connect to your cluster:

  1. In a terminal, run:
helm upgrade -i multiwoven
  1. Confirm a service named multiwoven-postgresql was created in the cluster.
  2. In a terminal, run:
helm upgrade -i multiwoven --set multiwovenPostgresql.enabled=false
  1. Confirm a service named multiwoven-postgresql is not available in the cluster.

Copy link

linear bot commented Apr 30, 2024

@RafaelOAiSquared RafaelOAiSquared marked this pull request as draft April 30, 2024 03:20
Copy link
Collaborator

@subintp subintp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RafaelOAiSquared Build is failing due to lint error. Please fix that.

@subintp subintp marked this pull request as ready for review April 30, 2024 17:17
@RafaelOAiSquared RafaelOAiSquared merged commit 643993d into main Apr 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants