Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PositionalEmbeddings.jl #14

Closed
AntonOresten opened this issue Dec 2, 2024 · 0 comments
Closed

Use PositionalEmbeddings.jl #14

AntonOresten opened this issue Dec 2, 2024 · 0 comments

Comments

@AntonOresten
Copy link
Member

I'm rewriting some stuff for type stability and Reactant.jl compilation, which includes creating a RoPE struct. Depending on how hackable we want this particular aspect to be, it might be worth using the PositionalEmbeddings.jl package for this, as I found the abstractions to converge.

See also #7
@murrellb murrellb closed this as completed Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@murrellb @AntonOresten