Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Refactor Art mappings to use the built in v12 function #911

Closed
PrototypeESBU opened this issue Oct 6, 2024 · 1 comment · Fixed by #912
Closed

Enhancement: Refactor Art mappings to use the built in v12 function #911

PrototypeESBU opened this issue Oct 6, 2024 · 1 comment · Fixed by #912
Assignees
Labels
enhancement New feature, request or improvement
Milestone

Comments

@PrototypeESBU
Copy link
Collaborator

In v12, there is a built in way of mapping artwork in compendiums. Investigate removing system built in and converting legacy mapping flags over to the new format. Existing mapping files appear compatible with the new build in method. Artwork mappings will then be managed in the core settings.

new module flags

"compendiumArtMappings": {
   "shadowdark": {
      "mapping": "modules/art-module/mapping-system-id.json",
      "credit": "<em>Portrait and token artwork by Art Module.</em>"
    }
}
@PrototypeESBU PrototypeESBU added the enhancement New feature, request or improvement label Oct 6, 2024
@PrototypeESBU PrototypeESBU self-assigned this Oct 7, 2024
@PrototypeESBU PrototypeESBU added this to the release-3.2.0 milestone Oct 7, 2024
@PrototypeESBU PrototypeESBU changed the title Enhancement: Refactor Art mappings to use the build in v12 function Enhancement: Refactor Art mappings to use the built in v12 function Oct 7, 2024
@Muttley
Copy link
Owner

Muttley commented Oct 10, 2024

In v12, there is a built in way of mapping artwork in compendiums.

Interesting. I was not aware they added that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, request or improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants