From e5a7357eaea5e5d45b18a74ebb0d6a0c5299fbb4 Mon Sep 17 00:00:00 2001 From: Jean-Yves Avenard Date: Wed, 3 Jul 2024 18:04:39 -0700 Subject: [PATCH] [WEBM] Seeking is broken https://bugs.webkit.org/show_bug.cgi?id=276171 rdar://128620836 Reviewed by Jer Noble and Youenn Fablet. Regression was introduced in 273109@main We never flushed the AVSampleBufferDisplayLayer nor re-enqueued new frames to be displayed when seeking backward. Added test * LayoutTests/media/media-vp8-webm-seek-to-start-expected.html: Added. * LayoutTests/media/media-vp8-webm-seek-to-start.html: Added. * LayoutTests/platform/mac-wk2/TestExpectations: * Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm: (WebCore::MediaPlayerPrivateWebM::seekInternal): Canonical link: https://commits.webkit.org/280648@main --- ...media-vp8-webm-seek-to-start-expected.html | 8 ++++++ .../media/media-vp8-webm-seek-to-start.html | 26 +++++++++++++++++++ .../mac-site-isolation/TestExpectations | 1 + LayoutTests/platform/mac-wk1/TestExpectations | 1 + LayoutTests/platform/mac-wk2/TestExpectations | 3 ++- .../graphics/cocoa/MediaPlayerPrivateWebM.mm | 2 +- 6 files changed, 39 insertions(+), 2 deletions(-) create mode 100644 LayoutTests/media/media-vp8-webm-seek-to-start-expected.html create mode 100644 LayoutTests/media/media-vp8-webm-seek-to-start.html diff --git a/LayoutTests/media/media-vp8-webm-seek-to-start-expected.html b/LayoutTests/media/media-vp8-webm-seek-to-start-expected.html new file mode 100644 index 0000000000000..0255320b434b8 --- /dev/null +++ b/LayoutTests/media/media-vp8-webm-seek-to-start-expected.html @@ -0,0 +1,8 @@ + + + +
+ END OF TEST
 +
+ + \ No newline at end of file diff --git a/LayoutTests/media/media-vp8-webm-seek-to-start.html b/LayoutTests/media/media-vp8-webm-seek-to-start.html new file mode 100644 index 0000000000000..92b02d69f0263 --- /dev/null +++ b/LayoutTests/media/media-vp8-webm-seek-to-start.html @@ -0,0 +1,26 @@ + + + +webm file with vp8 + + + + + +