Bugfix for issue #117; Update of list of data points for E3 devices to version 20250307

Author: MyHomeMyData

README.md

@@ -135,7 +135,9 @@ If you enjoyed this project — or just feeling generous, consider buying me a b
     ### **WORK IN PROGRESS**
 -->
 ### **WORK IN PROGRESS**
+* (MyHomeMyData) Bugfix for issue #117
 * (MyHomeMyData) Updated data point 381, refer to discussion https://github.com/open3e/open3e/discussions/212
+* (MyHomeMyData) Update of list of data points for E3 devices to version 20250307
 
 ### 0.10.7 (2025-02-26)
 * (MyHomeMyData) Updated dependencies according to issue #111

lib/canUds.js

@@ -394,10 +394,14 @@ class uds {
         // ======================
         if (id.includes(this.userReadByDidId)) {
             // User requests ReadByDid
-            const dids = JSON.parse(state.val);
-            await ctx.log.debug('User command UDS ReadByDid on '+this.config.stateBase+'. Dids='+JSON.stringify(dids));
-            await this.pushCmnd(ctx, 'read', dids);
-            await ctx.setStateAsync(id, { val: JSON.stringify(dids), ack: true }); // Acknowlegde user command
+            try {
+                const dids = JSON.parse(state.val);
+                await ctx.log.debug('User command UDS ReadByDid on '+this.config.stateBase+'. Dids='+JSON.stringify(dids));
+                await this.pushCmnd(ctx, 'read', dids);
+                await ctx.setStateAsync(id, { val: JSON.stringify(dids), ack: true }); // Acknowlegde user command
+            } catch(e) {
+                ctx.log.error('ReadByDid(): Parsing of list of DIDs failed on '+this.config.stateBase+'; err='+JSON.stringify(e)+' - You have to provide a list of numerical values.');
+            }
             return;
         }
 
@@ -439,12 +443,16 @@ class uds {
                 break;
             case 'raw':
                 // Change in raw data
-                byteArr = this.storage.storageDids.toByteArray(await JSON.parse(state.val));
-                if (byteArr) {
-                    await this.pushCmnd(ctx, 'write', [[did,byteArr]]);
-                    ctx.setTimeout(function(ctxWorker,did){ctxWorker.cmndsQueue.push({'mode':'read', 'did': did});},2500,this,did);    // Read value after 2500 ms
-                } else {
-                    ctx.log.error('User command UDS WriteByDid on '+this.config.stateBase+': Encoding of data failed.');
+                try {
+                    byteArr = this.storage.storageDids.toByteArray(await JSON.parse(state.val));
+                    if (byteArr) {
+                        await this.pushCmnd(ctx, 'write', [[did,byteArr]]);
+                        ctx.setTimeout(function(ctxWorker,did){ctxWorker.cmndsQueue.push({'mode':'read', 'did': did});},2500,this,did);    // Read value after 2500 ms
+                    } else {
+                        ctx.log.error('User command UDS WriteByDid on '+this.config.stateBase+': Encoding of data failed.');
+                    }
+                } catch(e) {
+                    ctx.log.error('WriteByDid(): Encoding of data failed on '+this.config.stateBase+'.'+String(did)+'; err='+JSON.stringify(e)+' - You have to provide JSON formatted data.');
                 }
                 break;
             case 'tree':

lib/didsE3.json

@@ -8907,16 +8907,58 @@
     }
   },
   "1006": {
-    "codec": "RawCodec",
+    "codec": "O3EComplexType",
     "len": 4,
     "id": "TargetQuickMode",
-    "args": {}
+    "args": {
+      "subTypes": [
+        {
+          "codec": "O3EByteVal",
+          "len": 1,
+          "id": "OpMode",
+          "args": {}
+        },
+        {
+          "codec": "O3EBool",
+          "len": 1,
+          "id": "Required",
+          "args": {}
+        },
+        {
+          "codec": "RawCodec",
+          "len": 2,
+          "id": "Unknown",
+          "args": {}
+        }
+      ]
+    }
   },
   "1007": {
-    "codec": "RawCodec",
+    "codec": "O3EComplexType",
     "len": 4,
     "id": "CurrentQuickMode",
-    "args": {}
+    "args": {
+      "subTypes": [
+        {
+          "codec": "O3EByteVal",
+          "len": 1,
+          "id": "OpMode",
+          "args": {}
+        },
+        {
+          "codec": "O3EBool",
+          "len": 1,
+          "id": "Required",
+          "args": {}
+        },
+        {
+          "codec": "RawCodec",
+          "len": 2,
+          "id": "Unknown",
+          "args": {}
+        }
+      ]
+    }
   },
   "1008": {
     "codec": "RawCodec",
@@ -32001,5 +32043,5 @@
       ]
     }
   },
-  "Version": "20250302"
+  "Version": "20250307"
 }