New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Servo doesn't use Servo config directly #1382

Open

supertick opened this issue Dec 13, 2023 · 0 comments

Contributor

supertick commented Dec 13, 2023

Describe the bug
It takes an additional servo.apply(servoConfig) to change idleTimeout and probably more values.

To Reproduce
Steps to reproduce the behavior:

    neck = Runtime.start("neck", "Servo");
    config = neck.getConfig();
    # change should immediately affect servo    
    config.idleTimeout = 5000;
    # legacy "mapping" to member vars requires "apply" to process
    neck.apply(config);
    # if the save was done without  the apply neck's idle timeout would be 3000
    neck.save();

Expected behavior
A clear and concise description of what you expected to happen.

    config.idleTimeout = 5000;
    neck.save()
    # neck.yml idleTimeout should equal 5000 (without the need of apply)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment