Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#50: Update en_US/cmu-arctic_low voice metadata #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bhiln
Copy link

@bhiln bhiln commented Sep 25, 2023

How to use this template

Under each heading below is a short outline of the information required. When submitting a PR, please delete this text and replace it with your own.

The CLA section can be deleted entirely.

Description

Update en_US/cmu-arctic_low config.json voice metadata to current size_bytes and sha256_sum

Type of PR

If your PR fits more than one category, there is a high chance you should submit more than one PR. Please consider this carefully before opening the PR.
Either delete those that do not apply, or add an x between the square brackets like so: - [x]

  • Bugfix
  • Feature implementation
  • Refactor of code (without functional changes)
  • Documentation improvements
  • Test improvements

Testing

This change can be tested with the Python API, confirming that the new voice metadata is equivalent to the actual config.json file metadata.

import os
import mimic3_tts
print("Expected", mimic3_tts._resources._VOICES["en_US/cmu-arctic_low"]["files"]["config.json"])
file_path = os.path.join(mimic3_tts.download.DEFAULT_VOICES_DOWNLOAD_DIR, "en_US/cmu-arctic_low/config.json")
print("Actual size_bytes", os.path.getsize(file_path))
with open(file_path, "rb") as f:
  print("Actual sha256_sum", mimic3_tts.utils.file_sha256_sum(f))

Documentation

Does documentation for this already exist? Are there docstrings on all the public methods you added or modified? Have these been updated?

Leaving the en_US/cmu-arctic_low version as is to match the version found here: https://github.com/MycroftAI/mimic3-voices/blob/master/voices/en_US/cmu-arctic_low/VERSION

CLA

To protect you, the project, and those who choose to use Mycroft technologies in systems they build, we ask all contributors to sign a Contributor License Agreement.

This agreement clarifies that you are granting a license to the Mycroft Project to freely use your work. Additionally, it establishes that you retain the ownership of your contributed code and intellectual property. As the owner, you are free to use your code in other work, obtain patents, or do anything else you choose with it.

If you haven't already signed the agreement and been added to our public Contributors repo then please head to https://mycroft.ai/cla to initiate the signing process.

@bhiln bhiln changed the title 50: Update en_US/cmu-arctic_low voice metadata #50: Update en_US/cmu-arctic_low voice metadata Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant