Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Check for duplicate wallet/contract window #130

Open
ixje opened this issue Mar 9, 2022 · 1 comment
Open

[UX] Check for duplicate wallet/contract window #130

ixje opened this issue Mar 9, 2022 · 1 comment

Comments

@ixje
Copy link

ixje commented Mar 9, 2022

Each click on a wallet or contract opens a new window without checking if the window was already open.
image

The default file explorer of VSCode does not seem to open duplicate windows when clicking a file so this feels like deviating behaviour from the default.

@ixje ixje changed the title Check for duplicate wallet/contract window [UX] Check for duplicate wallet/contract window Mar 9, 2022
@robliou
Copy link

robliou commented May 27, 2022

_//Update as of 5/28/22- actually this issue is still open. The reason I thought I had this issue fixed was because I had changed my setting

"workbench.editor.showTabs": false

and this resulted in only one tab showing up at a time. However, this is true for all tabs, not just for wallet or contract. Therefore, the problem is still there. Will have to find another solution for this.
//_

I removed the activation event from package.json which was triggering a wallet and/or contract being opened in a new window every time a user clicked on a wallet or contract on the side bar. Now a wallet/ contract opens up only once in the same window, so should be much less clutter. Should double check to make sure that this is what we want. See commit below:

4634306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants