Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create custom Menu Walker for adding Tailwind Classes #29

Open
ibes opened this issue Dec 28, 2020 · 2 comments
Open

Create custom Menu Walker for adding Tailwind Classes #29

ibes opened this issue Dec 28, 2020 · 2 comments

Comments

@michael-voit
Copy link
Member

Caching the menu is a great point, yes. I love fragment caching as a part for less unsustainable websites and think we should use it where it makes sense.

@ibes
Copy link
Collaborator Author

ibes commented Dec 31, 2020

Will spinwpup help us to cache nanu strong enough so that it will be not necessary to cache the menu?

For menu caching the best case is to cache one instance of the menu - but that would wipe stuff like "current-item" classes away. Adding that back via javascript would be possible but not my favorite.

Caching the menu for each page (to keep the current-item classes) sounds like a semi great solution.

I am not decided how relevant the highlighting of the current page is and if a clear site structure should work without highlighting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants