You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
elasticsearch_host seems to now require a protocol prefix, but this change isnt documented anywhere, the sample props still have elasticsearch_host=[YourElasticsearchHost]
fixed Elasticsearch http https validation #80 Doesn't actually catch the missing prefix as the check happens after the curl call. If the prefix is missing the curl call will fail and return before the check for the prefix happens.
Since it's no longer just the host, the variable itself should get renamed, maybe .._host and ..._port should both go away and be replaced with elasticsearch_url or something along those lines.
For future consideration, how should breaking changes like this be announced/documented? I was surprised when trying out the beta build that our install now fails, but I had to dig through github issues and commits/source code to find out why, not an ideal process. Maybe this project needs a public CHANGELOG ala Keep a Changelog in repo.
The text was updated successfully, but these errors were encountered:
And I agree with the including a CHANGELOG in the repo. I've made a branch for that and it'll have the notable additions and changes from the current version of the repo
elasticsearch_host
seems to now require a protocol prefix, but this change isnt documented anywhere, the sample props still haveelasticsearch_host=[YourElasticsearchHost]
.._host
and..._port
should both go away and be replaced withelasticsearch_url
or something along those lines.For future consideration, how should breaking changes like this be announced/documented? I was surprised when trying out the beta build that our install now fails, but I had to dig through github issues and commits/source code to find out why, not an ideal process. Maybe this project needs a public
CHANGELOG
ala Keep a Changelog in repo.The text was updated successfully, but these errors were encountered: