Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with elasticsearch_host changes #86

Open
Gillingham opened this issue Feb 9, 2022 · 2 comments
Open

Issues with elasticsearch_host changes #86

Gillingham opened this issue Feb 9, 2022 · 2 comments
Milestone

Comments

@Gillingham
Copy link

Gillingham commented Feb 9, 2022

  1. elasticsearch_host seems to now require a protocol prefix, but this change isnt documented anywhere, the sample props still have elasticsearch_host=[YourElasticsearchHost]
  2. fixed Elasticsearch http https validation #80 Doesn't actually catch the missing prefix as the check happens after the curl call. If the prefix is missing the curl call will fail and return before the check for the prefix happens.
  3. Since it's no longer just the host, the variable itself should get renamed, maybe .._host and ..._port should both go away and be replaced with elasticsearch_url or something along those lines.

For future consideration, how should breaking changes like this be announced/documented? I was surprised when trying out the beta build that our install now fails, but I had to dig through github issues and commits/source code to find out why, not an ideal process. Maybe this project needs a public CHANGELOG ala Keep a Changelog in repo.

@voxparcxls
Copy link
Collaborator

Hi @Gillingham , i'll be updating the Wiki https://wiki.jpl.nasa.gov/display/cws/CWS+Platform+Prerequisites before CWSv2.2 release with the new config details and features. It should be up by this coming Monday.

And I agree with the including a CHANGELOG in the repo. I've made a branch for that and it'll have the notable additions and changes from the current version of the repo

-Josh

@voxparcxls voxparcxls added this to the 2.3 milestone Mar 24, 2022
@voxparcxls
Copy link
Collaborator

Update:
#97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants