Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interproscan #104

Merged
merged 13 commits into from
Jan 12, 2024
Merged

Interproscan #104

merged 13 commits into from
Jan 12, 2024

Conversation

MartinPippel
Copy link
Contributor

replace local interproscan module (that is used in the functional annotation pipeline) with the NF-core module

  • this step can now run in parallel
  • cpus are set to 4 by default, which needs to tested and verified on real samples

Copy link
Collaborator

@mahesh-panchal mahesh-panchal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping the temperamental behavior of Interproscan in Nextflow would disappear. I wonder if this is because of the Nextflow version.

subworkflows/functional_annotation/main.nf Outdated Show resolved Hide resolved
config/nf-core-defaults.config Outdated Show resolved Hide resolved
config/test.config Outdated Show resolved Hide resolved
config/test.config Outdated Show resolved Hide resolved
config/test.config Outdated Show resolved Hide resolved
modules/nf-core/interproscan/main.nf Outdated Show resolved Hide resolved
@mahesh-panchal
Copy link
Collaborator

You also need to update the test config to use max 4 cores for interproscan. See failing actions.

@mahesh-panchal
Copy link
Collaborator

Ready to merge?

@MartinPippel MartinPippel merged commit fef4301 into NBISweden:master Jan 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants