Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a draft PR for cloud chemistry module #1

Open
mattldawson opened this issue Nov 19, 2024 · 0 comments
Open

Create a draft PR for cloud chemistry module #1

mattldawson opened this issue Nov 19, 2024 · 0 comments
Assignees

Comments

@mattldawson
Copy link
Collaborator

mattldawson commented Nov 19, 2024

Issue Type

Code Clean-up

Issue Description

Create a draft pull request for cloud chemistry so that the code can be reviewed.

Ideas

  • duplicate the existing here, here, here
  • rename the modules to cloud_aqueous_chemistry, mam_clouds, carma_clouds, with corresponding file names
  • start from the Francis's development branch
  • things to consider in review
    • missing descriptions for units for variables
    • missing descriptions of functions and function arguments
    • unused variables
    • cryptically named variables
    • dead code blocks
    • potential to break up large code blocks, and introduce reusable/testable functions
    • compare MAM and CARMA code for consistency
    • identify host-model vs aerosol-model portions of the code
    • separate configuration data from algorithms
    • magic numbers

Will this change answers?

Yes

Will you be implementing this yourself?

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant