-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
158 create an action to test the build and packaging of the python target #165
Merged
mattldawson
merged 33 commits into
main
from
158-create-an-action-to-test-the-build-and-packaging-of-the-python-target
Jun 26, 2024
Merged
158 create an action to test the build and packaging of the python target #165
mattldawson
merged 33 commits into
main
from
158-create-an-action-to-test-the-build-and-packaging-of-the-python-target
Jun 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…8-create-an-action-to-test-the-build-and-packaging-of-the-python-target
…ackaging-of-the-python-target
boulderdaze
reviewed
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
boulderdaze
approved these changes
Jun 25, 2024
mattldawson
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #158
Additionally, the cmake version is parsed by the docs and the pyproject.toml files so that we only need to update the version number in one place and documentation and python releases will use the same version.