Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests failing (OK for now after pinning Zarr) #62

Closed
valeriupredoi opened this issue Mar 6, 2023 · 5 comments · Fixed by #65
Closed

Unit tests failing (OK for now after pinning Zarr) #62

valeriupredoi opened this issue Mar 6, 2023 · 5 comments · Fixed by #65
Assignees
@valeriupredoi
Labels
bug Something isn't working testing testing duh

Comments

@valeriupredoi
Copy link
Collaborator

valeriupredoi commented Mar 6, 2023 •
edited
Loading

Our tests are currently failing, see fails - it's very possible new versions of fsspec have changed their API, I will check this now (cheers @davidhassell for alerting me 🍺 )
@valeriupredoi valeriupredoi added bug Something isn't working testing testing duh labels Mar 6, 2023
@valeriupredoi valeriupredoi self-assigned this Mar 6, 2023
@valeriupredoi
Copy link
Collaborator Author

Correction it's not fspec but zarr - the break appears after zarr>2.13.3

@valeriupredoi
Copy link
Collaborator Author

OK this is the PR causing this - it seems they have forgotten to update the API - I'll raise an Issue zarr-developers/zarr-python#1304

@valeriupredoi
Copy link
Collaborator Author

with 2.13.3 our object is:

<KVStore: 
<fsspec.mapping.FSMap object at 0x7ff62cd21630>
 at 0x7ff62cd22140>

with 2.13.6 our object becomes:

<zarr.storage.FSStore object at 0x7f3120e6d5d0>

so there is a difference in the way the object is treated from one version to another 🤦‍♂️

@valeriupredoi
Copy link
Collaborator Author

@davidhassell @bnlawrence I opened this zarr-developers/zarr-python#1362 and right now am gonna pin zarr in our env 👍

@valeriupredoi valeriupredoi mentioned this issue Mar 6, 2023
Merged
@valeriupredoi
Copy link
Collaborator Author

we now have a working setup again after #63 but am keeping this open still - am working with the Zarr folks in that issue, and will close ony when we can unpin Zarr and either implement what they recommend, or they fix their bug 👍

@valeriupredoi valeriupredoi changed the title Unit tests failing Unit tests failing (OK for now after pinning Zarr) Mar 6, 2023
This was referenced Mar 6, 2023
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valeriupredoi valeriupredoi

Labels
bug Something isn't working testing testing duh
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pin Zarr >=2.13.6 so we use new FSStore objects (instead of KVStore) NCAS-CMS/PyActiveStorage
1 participant
@valeriupredoi