Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new recipe (18) by summer student: correlation calculation #820

Merged
merged 12 commits into from
Nov 8, 2024

Conversation

sadielbartholomew
Copy link
Member

The final recipe created by Natalia, which again I have updated a bit to produce only one output plot, of best quality, as per the other recipes with a STDOUT report of the calculation output, plus to tidy and add further comment detail e.g. to describe the data sources. All things Natalia could have done herself had she had more time than the two weeks placement!

Expected output

final-recipe-18

@sadielbartholomew sadielbartholomew added the documentation Improvements or additions to documentation label Oct 9, 2024
@sadielbartholomew sadielbartholomew self-assigned this Oct 9, 2024
Comment on lines +32 to +33
orog = cf.read("~/recipes/1km_elevation.nc")[0]
snow = cf.read("~/recipes/snowcover")[0]
Copy link
Member Author

@sadielbartholomew sadielbartholomew Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both of these are new datasets we need to have available for the recipes as a whole, so I have uploaded them to the 'recipes' Google Drive folder in readiness.

@sadielbartholomew
Copy link
Member Author

sadielbartholomew commented Nov 8, 2024

Given how busy Ankit is with his PhD we have agreed I can merge this without review. At release time I will enact the plan I outlined above:

let me suggest that I add all five recipes via PRs like this one, with the Python script and addition to the recipe_list.txt, then I do a final PR where I add all of the built material from those five to the repo finally, show they show up on the site

So, merging, and there will eventually be a follow-on PR to get all the new recipes built and included.

@sadielbartholomew sadielbartholomew merged commit b5c40da into NCAS-CMS:main Nov 8, 2024
@sadielbartholomew sadielbartholomew deleted the student-recipes-3 branch November 8, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant