You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The released version of the genome downloader should support comma-separated lists. "This is supported in the 0.2.6 release that I just pushed to github and pypi." (Response to Issue 55 on their github).
We should test our wrapper script with comma-separated list - at least these two cases:
"correct" formulation: something1, something2, something3
trailing delimiter: something1, something2, something3,
(If the trailing delimiter breaks things, we should document that for the user because it's easy to end up with that from quick-and-dirty concatenation scripts.)
Assuming that works, we should update (not remove) the first caveat in the documentTaxList function of the wrapper script. We should not remove the information because users may be using a previously installed version of genome downloader. Could change
echo " The released ncbi-genome-downloader currently does not accept a comma-separated list."
to echo " Versions of the ncbi-genome-downloader earlier than 0.2.6 do not accept a comma-separated list. Upgrade to the latest version for this functionality."
The text was updated successfully, but these errors were encountered:
Hey, I just gave it a spin on my end and using a comma-separated list works if you're running the 0.2.6 version of the NCBI genome downloader. Having said this: To get the version 0.2.6 I still had to clone their repository and do pip install . from that clone, PyPI did continue to give me the older version. But either way I think we can update the caveat as upcoming versions will support this.
The released version of the genome downloader should support comma-separated lists. "This is supported in the 0.2.6 release that I just pushed to github and pypi." (Response to Issue 55 on their github).
"correct" formulation: something1, something2, something3
trailing delimiter: something1, something2, something3,
(If the trailing delimiter breaks things, we should document that for the user because it's easy to end up with that from quick-and-dirty concatenation scripts.)
echo " The released ncbi-genome-downloader currently does not accept a comma-separated list."
to
echo " Versions of the ncbi-genome-downloader earlier than 0.2.6 do not accept a comma-separated list. Upgrade to the latest version for this functionality."
The text was updated successfully, but these errors were encountered: