Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicator while waiting for post to be submitted and page refreshed ( when "Don't ask again" is enabled ) #680

Closed
petersalomonsen opened this issue Mar 2, 2024 · 4 comments · Fixed by #687
Assignees
Labels
enhancement New feature or request

Comments

@petersalomonsen
Copy link
Collaborator

petersalomonsen commented Mar 2, 2024

Is your feature request related to a problem? Please describe.

When "Don't ask again" is enabled, I'm able to submit a post without confirming with the wallet. Still there are some delays, without any indication, that might lead me to think that I need to reload the page.

Here's a video ( turn audio on ) that demonstrates these delays, where you can see there is no indication that I need to wait:

dontaskagain.mp4

Describe the solution you'd like

I would like a toast to show up immediately when I click the submit button, in the delay between the button was clicked and the transaction sending starts. Also I would like a toast to show up when the transaction is completed from the VM, but while still refreshing the page is not completed. This way I would have a clear indication that I don't need to reload the page.

@frol
Copy link
Collaborator

frol commented Mar 4, 2024

Following the normal Web2 world practices:

  1. The form should become inactive (button should be disabled), so duplicates cannot be posted
  2. There should be some loader (toast or an overlay, I don't have a preference) or optimistic posting happen
  3. We should implement such a strategy, so if a user has a bad internet connection or their browser crashes, or they reload the page, etc, the inputs should never be lost unless the input is explicitly canceled or has already been published.

@petersalomonsen petersalomonsen self-assigned this Mar 4, 2024
@petersalomonsen
Copy link
Collaborator Author

Following the normal Web2 world practices:

  1. The form should become inactive (button should be disabled), so duplicates cannot be posted
  2. There should be some loader (toast or an overlay, I don't have a preference) or optimistic posting happen
  3. We should implement such a strategy, so if a user has a bad internet connection or their browser crashes, or they reload the page, etc, the inputs should never be lost unless the input is explicitly canceled or has already been published.

Thanks, that makes sense! I'll look into this

@petersalomonsen petersalomonsen moved this from 🆕 Triage to 🏗 In progress in 🚀 DevHub Products Mar 5, 2024
@petersalomonsen
Copy link
Collaborator Author

@ori-near Please look in the Pull Request for updates on this issue. Also see the checklist I've added there for what's remaining.

@petersalomonsen
Copy link
Collaborator Author

@ori-near @frol There is now a test-generated video in the Pull Request description that demonstrates the fix of adding a load indicator and hiding the submit/cancel buttons while the transaction is sent and while waiting for refresh.

@frol frol closed this as completed in #687 Mar 11, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in 🚀 DevHub Products Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants