Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Drop work for cancelled exports #8

Open
PierreLeGuen opened this issue Aug 22, 2023 · 0 comments
Open

Make Drop work for cancelled exports #8

PierreLeGuen opened this issue Aug 22, 2023 · 0 comments
Assignees
@PierreLeGuen
Labels
bug Something isn't working

Comments

@PierreLeGuen
Copy link
Member

Currently requested reports are not cancelled in the backend. They will continue to run even if the client cencelled his request. This is due to the tta_service being passed as a global state to endpoint. It can't be dropped after one request is cancelled.

Solution:

  • Clone tta service per request.
  • Move the rate limiter outside of the tta service. Pass it as a param.
@PierreLeGuen PierreLeGuen added the bug Something isn't working label Aug 22, 2023
@PierreLeGuen PierreLeGuen self-assigned this Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PierreLeGuen PierreLeGuen

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PierreLeGuen