Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve plotting behaviour and labelling #89

Merged
merged 8 commits into from
Aug 2, 2024

Conversation

cbueth
Copy link
Collaborator

@cbueth cbueth commented Jul 22, 2024

Improve plotting behaviour and labelling from #88.

cbueth and others added 5 commits July 22, 2024 16:04
- Show all plots after running
- Better as `plt.show()` is a blocking function. Many windows, but program not stalling
- move distance matrix plot to logging mode 'debug'
@cbueth cbueth linked an issue Jul 22, 2024 that may be closed by this pull request
@cbueth cbueth force-pushed the 88-joss-review-questions-on-00-mwepy branch from 3207758 to 2fab349 Compare July 22, 2024 16:03
@cbueth cbueth force-pushed the 88-joss-review-questions-on-00-mwepy branch from 2fab349 to a9c526b Compare July 22, 2024 16:14
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.

Project coverage is 94.43%. Comparing base (671f22a) to head (a1fa69a).

Files Patch % Lines
superblockify/metrics/metric.py 0.00% 4 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
- Coverage   94.73%   94.43%   -0.30%     
==========================================
  Files          31       31              
  Lines        1881     1870      -11     
  Branches      444      446       +2     
==========================================
- Hits         1782     1766      -16     
- Misses          0        4       +4     
- Partials       99      100       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cbueth cbueth force-pushed the 88-joss-review-questions-on-00-mwepy branch from b48d886 to a1fa69a Compare August 2, 2024 10:17
@cbueth cbueth merged commit 33e043f into main Aug 2, 2024
58 checks passed
@cbueth cbueth deleted the 88-joss-review-questions-on-00-mwepy branch August 2, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JOSS review: questions on 00-mwe.py
2 participants