Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FATES_FUEL_AMOUNT(_AP) incorrectly kg instead of kg/m2 #1219

Closed
samsrabin opened this issue Jul 8, 2024 · 1 comment
Closed

FATES_FUEL_AMOUNT(_AP) incorrectly kg instead of kg/m2 #1219

samsrabin opened this issue Jul 8, 2024 · 1 comment

Comments

@samsrabin
Copy link
Contributor

The units of both these output variables are kg/m2. However, when they're calculated in FatesHistoryInterfaceMod, they're calculated as kg. The multiplications by cpatch%area in the below snippets need to be followed by divisions by site area (for FATES_FUEL_AMOUNT) or age class area (for FATES_FUEL_AMOUNT_AP), but those divisions never happen.

FATES_FUEL_AMOUNT:

hio_sum_fuel_si(io_si)             = hio_sum_fuel_si(io_si) + cpatch%sum_fuel * cpatch%area * AREA_INV

FATES_FUEL_AMOUNT_AP:

 hio_fire_sum_fuel_si_age(io_si, cpatch%age_class) = hio_fire_sum_fuel_si_age(io_si, cpatch%age_class) +  &
    cpatch%sum_fuel * cpatch%area * AREA_INV

There may be other variables with this problem.

(Originally discovered as part of #1205, but this is a more fundamental issue.)

@samsrabin
Copy link
Contributor Author

No; cpatch%sum_fuel is kg/m2, not kg.

@github-project-automation github-project-automation bot moved this from ❕Todo to ✔ Done in FATES issue board Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

1 participant