Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logic around test on hlm_pft_map test plus a couple other things #798

Merged
merged 1 commit into from
Oct 27, 2021

Conversation

ckoven
Copy link
Contributor

@ckoven ckoven commented Oct 23, 2021

this fixes the issue noted here: #782 (comment) where the hlm_pft_map test was happening even when fixed_biogeog was not true.

also some other tiny things that have been building up in a cleaning branch: there was an unused patch variable repro in EDTypesMod that I deleted, and there was some incorrect documentation in FatesAllometryMod that I fixed.

Should be b4b.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the in-code documentation .AND. (the technical note .OR. the wiki) accordingly.
  • I have read the CONTRIBUTING document.
  • FATES PASS/FAIL regression tests were run
  • If answers were expected to change, evaluation was performed and provided

Not yet tested, except to confirm that it builds and runs.

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

Copy link
Contributor

@rgknox rgknox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rgknox rgknox merged commit b622257 into NGEET:master Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants