You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Commit 0954553 added two additional versions of the SWAN script.
The original "combineTimeSeries_SWAN.R" in the "R" folder contains a wrapper function I wrote to execute PECBMS functions "Check_steering_files", "Check_steering_files_combined", "Check_input", and - most importantly - "Run_Swan".
This remains unchanged.
A new file with the same name "combineTimeSeries_SWAN.R" was added to the folder "data" (where it is unlikely to belong). However, this file is not equivalent to "R/combineTimeSeries_SWAN.R". It's a very long and messy script that seems to overlap with parts of "R/03_Swan_Euromonitoring_v8.R", but does not use any of the functions specified within the latter. It's not clear what this file ("data/combineTimeSeries_SWAN.R") is, and what role it fulfills. Not least because it has no link to the master script.
Additionally, there's another new file in the main folder called "combineTimeSeries_SWAN_UpdateJaviDec2024.R". This seems to be identical to the above mentioned "data/combineTimeSeries_SWAN.R". Identity and purpose of this script are also not clear, and it is not linked to the master script either.
We need to clarify what these files are, whether we need them, and - if so - where in the workflow they fit in (it seems quite obvious that they are NOT replacements for "R/combineTimeSeries_SWAN.R".
The text was updated successfully, but these errors were encountered:
I note that as part of the same commit as these extra files were added, we have had an update to "data/Species_Countries.csv" and "data/Swan_schedules.csv". There has also been an addition of a .txt version of "Species_Countries" as a consequence of an addition to "R/correctFirstSurveyYear_SWAN.R".
ChloeRN
changed the title
Multiple versions of SWAN script after update
Multiple versions of SWAN script after update?
Jan 31, 2025
Commit 0954553 added two additional versions of the SWAN script.
The original "combineTimeSeries_SWAN.R" in the "R" folder contains a wrapper function I wrote to execute PECBMS functions "Check_steering_files", "Check_steering_files_combined", "Check_input", and - most importantly - "Run_Swan".
This remains unchanged.
A new file with the same name "combineTimeSeries_SWAN.R" was added to the folder "data" (where it is unlikely to belong). However, this file is not equivalent to "R/combineTimeSeries_SWAN.R". It's a very long and messy script that seems to overlap with parts of "R/03_Swan_Euromonitoring_v8.R", but does not use any of the functions specified within the latter.
It's not clear what this file ("data/combineTimeSeries_SWAN.R") is, and what role it fulfills. Not least because it has no link to the master script.
Additionally, there's another new file in the main folder called "combineTimeSeries_SWAN_UpdateJaviDec2024.R". This seems to be identical to the above mentioned "data/combineTimeSeries_SWAN.R". Identity and purpose of this script are also not clear, and it is not linked to the master script either.
We need to clarify what these files are, whether we need them, and - if so - where in the workflow they fit in (it seems quite obvious that they are NOT replacements for "R/combineTimeSeries_SWAN.R".
The text was updated successfully, but these errors were encountered: