Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check default values for mocsy constants? #74

Open
andrew-c-ross opened this issue Jun 25, 2024 · 0 comments
Open

Check default values for mocsy constants? #74

andrew-c-ross opened this issue Jun 25, 2024 · 0 comments
Labels
question Further information is requested

Comments

@andrew-c-ross
Copy link
Contributor

The CO2 calculations have a few constants that can be set:

character(len=3) :: boron_formulation = 'l10'
character(len=3) :: dissociation_constants = 'm10'
character(len=2) :: hf_equilibrium_constant = 'dg'

Sam has previously noted that the defaults are not what was recommended by Orr et al. 2015. After we make the changes in #72 we could check whether there should be any changes to these defaults.

@andrew-c-ross andrew-c-ross added the question Further information is requested label Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant