added parameter names/comments for several dozen additional foodweb parameters #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliestock
added
documentation
yichengt900
reviewed
Oct 7, 2024
generic_tracers/generic_COBALT.F90
Outdated
| !---------------------------------------------------------------------- | ||
| ! Partitioning of zooplankton ingestion to other compartments | ||
| !---------------------------------------------------------------------- | ||
| ! Prey consumed by zooplankton is either used to produce new zooplankton biomass (anabolic matabolism), respired |
yichengt900
reviewed
Oct 7, 2024
generic_tracers/generic_COBALT.F90
Outdated
| ! total 100.0% 100.0% | ||
| ! | ||
| ! IF YOU CHOOSE TO ALTER THESE PARAMETERS, BE SURE TO ALTER THEM IN A MANNER THAT ENSURES THAT ALL UNDIGESTED | ||
| ! MATERIAL IN ACCOUNTED FOR. IF YOU CHANGE ONE, YOU MAY NEED TO CHANGE OTHERS! |
yichengt900
reviewed
Oct 7, 2024
generic_tracers/generic_COBALT.F90
Outdated
| "fraction of ingestion by medium zooplankton to detritus", units="none", default=0.15) | ||
| call get_param(param_file, "generic_COBALT", "phi_det_lgz", zoo(3)%phi_det, & | ||
| "fraction of ingestion by large zooplankton to detritus", units="none", default=0.30) | ||
| ! partitioning of zooplanton ingestion to labile dissolved organic material |
There was a problem hiding this comment.
Thanks @yichengt900. I'll have these corrected in a new commit shortly.
yichengt900
reviewed
Oct 7, 2024
There was a problem hiding this comment.
@charliestock , all look good to me! There are only a few tiny typos.
yichengt900
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
@charliestock, thank you for the prompt update! Everything looks good now, and I approve the changes. However, I will wait a little longer to allow others time to review as well.
|
Thanks all. Perhaps we can merge now that we have two reviews? Once this is in, I will add a pull request for the bug fix that addresses the issue that Xiao raised so that people can start evaluating in their regional and global configurations. @yichengt900 @gabyneg @jessluo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes the names and comments for several dozen additional foodweb parameters with the MOM6-style formatting. I think these are the last of the foodweb-linked parameters. I will sweep through the entire parameter setting section again over the next week to ensure that we have all of them in the new formatting, but I think these are ready to go. This pull request should not change answers.