Tentative changes from final version used for photoacclimation experiments #12
Conversation
| call g_tracer_add_param('p_2_n_min_Sm', phyto(SMALL)%p_2_n_min,1.0/23.0 ) ! mol P mol N-1 | ||
| call g_tracer_add_param('p_2_n_slope_Sm', phyto(SMALL)%p_2_n_slope, 0.0*1.0e6) ! mol P mol N-1 mol P-1 kg | ||
| call g_tracer_add_param('p_2_n_max_Sm', phyto(SMALL)%p_2_n_max,1.0/23.0 ) ! mol P mol N-1 | ||
| call g_tracer_add_param('p_2_n_min_Md', phyto(MEDIUM)%p_2_n_min,1.0/18.0 ) ! mol P mol N-1 | ||
| call g_tracer_add_param('p_2_n_slope_Md', phyto(MEDIUM)%p_2_n_slope, 0.0*1.0e6) ! mol P mol N-1 mol P-1 kg | ||
| call g_tracer_add_param('p_2_n_max_Md', phyto(MEDIUM)%p_2_n_max,1.0/18.0 ) ! mol P mol N-1 | ||
| call g_tracer_add_param('p_2_n_min_Lg', phyto(LARGE)%p_2_n_min,1.0/14.0 ) ! mol P mol N-1 | ||
| call g_tracer_add_param('p_2_n_slope_Lg', phyto(LARGE)%p_2_n_slope, 0.0*1.0e6) ! mol P mol N-1 mol P-1 kg |
There was a problem hiding this comment.
I think I see what's going on here now... this is effectively disabling the variable n:p, right? So this should not be merged.
|
Thanks @andrew-c-ross! @charliestock, based on @nikizadehgfdl's comments during the |
|
@charliestock, following our discussion, I think we will eventually go down the route of providing users with our recommended BGC parameters through a separate file, rather than editing the default values in the code. If so, I will close this PR for now and keep it as a reference. @andrew-c-ross are you ok with that? |
|
I think that sounds ok. Yeah I will keep my branch around, so with that branch and this closed PR we can always compare values if needed. |
This PR would make COBALT equivalent to the version found in Charlie's generic_COBALT_08222023_control.F90. Some of the changes in this PR are specific to the needs of the global photoacclimation runs, however, and shouldn't be merged. Reviews would be appreciated to identify what should or shouldn't be merged.