Simplify changes to the generic tracer interface for cobalt-p4: ocean_BGC side #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yichengt900
requested review from
andrew-c-ross,
amoebaliz,
charliestock and
theresa-morrison
theresa-morrison
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to address #7 .
The new cobalt-p4 requires several variables from MOM6 (e.g.
geolatfor day-length calculation as well aseqs_of_statefor density calculation).We revisited the initial modifications and removed unnecessary changes to minimize the impact on the generic tracer interface at the ocean_BGC side. The results match those obtained from the original codes in the 1-D and NWA12 RT tests.
I will conduct a 5-year run to ensure the consistency of the results.
Update The restart files from this PR (
/gpfs/f5/gfdl_med/scratch/Yi-cheng.Teng/fre/g_tracer/NWA12/NWA12_COBALT_2023_10_v2/ncrc5.intel22-prod/archive/restart) are identical to the baselines (/gpfs/f5/cefi/scratch/Yi-cheng.Teng/fre/cefi/NWA12/NWA12_COBALT_2023_10_v2/ncrc5.intel22-prod/archive).Dependency: NOAA-CEFI-Regional-Ocean-Modeling/MOM6#3